sabirvirtuoso/Mockit

View on GitHub
Mockit/Classes/TypeMatcher.swift

Summary

Maintainability
D
1 day
Test Coverage

Function match has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
    switch (arg, withArg) {
      case (let firstArg as Dictionary<String, Any?>, let secondArg as Dictionary<String, Any?>):
        return match(firstArg, withDictionary: secondArg)
      case (let firstArg as Dictionary<String, String?>, let secondArg as Dictionary<String, String?>):
Severity: Minor
Found in Mockit/Classes/TypeMatcher.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function match has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
    switch (arg, withArg) {
      case (let firstArg as Dictionary<String, Any>, let secondArg as Dictionary<String, Any>):
        return match(firstArg, withDictionary: secondArg)
      case (let firstArg as Dictionary<String, String>, let secondArg as Dictionary<String, String>):
Severity: Minor
Found in Mockit/Classes/TypeMatcher.swift - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function match has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
    switch (arg, withArg) {
      case (let firstArg as Dictionary<String, Any?>, let secondArg as Dictionary<String, Any?>):
        return match(firstArg, withDictionary: secondArg)
      case (let firstArg as Dictionary<String, String?>, let secondArg as Dictionary<String, String?>):
Severity: Minor
Found in Mockit/Classes/TypeMatcher.swift - About 1 hr to fix

    Function match has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
        switch (arg, withArg) {
          case (let firstArg as Dictionary<String, Any>, let secondArg as Dictionary<String, Any>):
            return match(firstArg, withDictionary: secondArg)
          case (let firstArg as Dictionary<String, String>, let secondArg as Dictionary<String, String>):
    Severity: Minor
    Found in Mockit/Classes/TypeMatcher.swift - About 1 hr to fix

      Function match has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
          case (let firstArg as Array<Any?>, let secondArg as Array<Any?>):
            return match(firstArg, withArray: secondArg)
          case (let firstArg as Array<String?>, let secondArg as Array<String?>):
      Severity: Minor
      Found in Mockit/Classes/TypeMatcher.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function match has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
            case (let firstArg as Array<Any>, let secondArg as Array<Any>):
              return match(firstArg, withArray: secondArg)
            case (let firstArg as Array<String>, let secondArg as Array<String>):
      Severity: Minor
      Found in Mockit/Classes/TypeMatcher.swift - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      public class StringMatcher: TypeMatcher {
      
        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
            case (let firstArg as String, let secondArg as String):
      Severity: Major
      Found in Mockit/Classes/TypeMatcher.swift and 4 other locations - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 57..68
      Mockit/Classes/TypeMatcher.swift on lines 74..85
      Mockit/Classes/TypeMatcher.swift on lines 91..102
      Mockit/Classes/TypeMatcher.swift on lines 108..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      public class DoubleMatcher: TypeMatcher {
      
        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
            case (let firstArg as Double, let secondArg as Double):
      Severity: Major
      Found in Mockit/Classes/TypeMatcher.swift and 4 other locations - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 40..51
      Mockit/Classes/TypeMatcher.swift on lines 57..68
      Mockit/Classes/TypeMatcher.swift on lines 74..85
      Mockit/Classes/TypeMatcher.swift on lines 108..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      public class IntMatcher: TypeMatcher {
      
        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
            case (let firstArg as Int, let secondArg as Int):
      Severity: Major
      Found in Mockit/Classes/TypeMatcher.swift and 4 other locations - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 40..51
      Mockit/Classes/TypeMatcher.swift on lines 57..68
      Mockit/Classes/TypeMatcher.swift on lines 91..102
      Mockit/Classes/TypeMatcher.swift on lines 108..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      public class FloatMatcher: TypeMatcher {
      
        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
            case (let firstArg as Float, let secondArg as Float):
      Severity: Major
      Found in Mockit/Classes/TypeMatcher.swift and 4 other locations - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 40..51
      Mockit/Classes/TypeMatcher.swift on lines 57..68
      Mockit/Classes/TypeMatcher.swift on lines 74..85
      Mockit/Classes/TypeMatcher.swift on lines 91..102

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

      public class BoolMatcher: TypeMatcher {
      
        public func match(argument arg: Any, withArgument withArg: Any) -> Bool {
          switch (arg, withArg) {
            case (let firstArg as Bool, let secondArg as Bool):
      Severity: Major
      Found in Mockit/Classes/TypeMatcher.swift and 4 other locations - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 40..51
      Mockit/Classes/TypeMatcher.swift on lines 74..85
      Mockit/Classes/TypeMatcher.swift on lines 91..102
      Mockit/Classes/TypeMatcher.swift on lines 108..119

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 84.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        fileprivate func match<T: Any>(_ array: Array<T>, withArray: Array<T>) -> Bool {
          guard array.count == withArray.count else {
            return false
          }
      
      
      Severity: Minor
      Found in Mockit/Classes/TypeMatcher.swift and 1 other location - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 146..154

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

        fileprivate func match<T: Any>(_ array: Array<T?>, withArray: Array<T?>) -> Bool {
          guard array.count == withArray.count else {
            return false
          }
      
      
      Severity: Minor
      Found in Mockit/Classes/TypeMatcher.swift and 1 other location - About 1 hr to fix
      Mockit/Classes/TypeMatcher.swift on lines 183..191

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 69.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 10 locations. Consider refactoring.
      Open

      //
      //  Mockit
      //
      //  Copyright (c) 2016 Syed Sabir Salman-Al-Musawi <sabirvirtuoso@gmail.com>
      //
      Severity: Major
      Found in Mockit/Classes/TypeMatcher.swift and 9 other locations - About 55 mins to fix
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313
      Mockit/Classes/TypeMatcher.swift on lines 1..313

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 63.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status