saltstack/salt

View on GitHub

Showing 9,400 of 17,590 total issues

File minion.py has 2953 lines of code (exceeds 250 allowed). Consider refactoring.
Open

# -*- coding: utf-8 -*-
'''
Routines to set up a minion
'''
# Import python libs
Severity: Major
Found in salt/minion.py - About 1 wk to fix

    File git.py has 2907 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    # -*- coding: utf-8 -*-
    '''
    States to manage git repositories and git configuration
    
    .. important::
    Severity: Major
    Found in salt/states/git.py - About 1 wk to fix

      File __init__.py has 2868 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      # -*- coding: utf-8 -*-
      '''
      All salt configuration loading and defaults should be in this module
      '''
      
      
      Severity: Major
      Found in salt/config/__init__.py - About 1 wk to fix

        Function vm_present has a Cognitive Complexity of 387 (exceeds 5 allowed). Consider refactoring.
        Open

        def vm_present(name, vmconfig, config=None):
            '''
            Ensure vm is present on the computenode
        
            name : string
        Severity: Minor
        Found in salt/states/smartos.py - About 1 wk to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        File cloud.py has 2764 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        # -*- coding: utf-8 -*-
        '''
        Utility functions for salt.cloud
        '''
        
        
        Severity: Major
        Found in salt/utils/cloud.py - About 1 wk to fix

          File parsers.py has 2735 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          # -*- coding: utf-8 -*-
          '''
              :codeauthor: Pedro Algarvio (pedro@algarvio.me)
          
          
          
          Severity: Major
          Found in salt/utils/parsers.py - About 1 wk to fix

            File pkg.py has 2699 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            # -*- coding: utf-8 -*-
            '''
            Installation of packages using OS package managers such as yum or apt-get
            =========================================================================
            
            
            Severity: Major
            Found in salt/states/pkg.py - About 1 wk to fix

              File gitfs.py has 2672 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              # -*- coding: utf-8 -*-
              '''
              Classes which provide the shared base for GitFS, git_pillar, and winrepo
              '''
              
              
              Severity: Major
              Found in salt/utils/gitfs.py - About 1 wk to fix

                File lxd.py has 2670 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                # -*- coding: utf-8 -*-
                '''
                Module for managing the LXD daemon and its containers.
                
                .. versionadded:: 2019.2.0
                Severity: Major
                Found in salt/modules/lxd.py - About 1 wk to fix

                  Function mounted has a Cognitive Complexity of 363 (exceeds 5 allowed). Consider refactoring.
                  Open

                  def mounted(name,
                              device,
                              fstype,
                              mkmnt=False,
                              opts='defaults',
                  Severity: Minor
                  Found in salt/states/mount.py - About 1 wk to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  File msazure.py has 2587 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  # -*- coding: utf-8 -*-
                  '''
                  Azure Cloud Module
                  ==================
                  
                  
                  Severity: Major
                  Found in salt/cloud/clouds/msazure.py - About 1 wk to fix

                    File bigip.py has 2509 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    # -*- coding: utf-8 -*-
                    '''
                    A state module designed to enforce load-balancing configurations for F5 Big-IP entities.
                        :maturity:      develop
                        :platform:      f5_bigip_11.6
                    Severity: Major
                    Found in salt/states/bigip.py - About 1 wk to fix

                      File yumpkg.py has 2501 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      # -*- coding: utf-8 -*-
                      '''
                      Support for YUM/DNF
                      
                      .. important::
                      Severity: Major
                      Found in salt/modules/yumpkg.py - About 1 wk to fix

                        Function _writeAdminTemplateRegPolFile has a Cognitive Complexity of 335 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def _writeAdminTemplateRegPolFile(admtemplate_data,
                                                          adml_language='en-US',
                                                          registry_class='Machine'):
                            r'''
                            helper function to prep/write adm template data to the Registry.pol file
                        Severity: Minor
                        Found in salt/modules/win_lgpo.py - About 6 days to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        Function os_data has a Cognitive Complexity of 317 (exceeds 5 allowed). Consider refactoring.
                        Open

                        def os_data():
                            '''
                            Return grains pertaining to the operating system
                            '''
                            grains = {
                        Severity: Minor
                        Found in salt/grains/core.py - About 6 days to fix

                        Cognitive Complexity

                        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                        A method's cognitive complexity is based on a few simple rules:

                        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                        • Code is considered more complex for each "break in the linear flow of the code"
                        • Code is considered more complex when "flow breaking structures are nested"

                        Further reading

                        File boto_vpc.py has 2343 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        # -*- coding: utf-8 -*-
                        '''
                        Connection module for Amazon VPC
                        
                        .. versionadded:: 2014.7.0
                        Severity: Major
                        Found in salt/modules/boto_vpc.py - About 6 days to fix

                          File core.py has 2280 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          # -*- coding: utf-8 -*-
                          '''
                          The static grains, these are the core, or built in grains.
                          
                          When grains are loaded they are not loaded in the same way that modules are
                          Severity: Major
                          Found in salt/grains/core.py - About 6 days to fix

                            File aptpkg.py has 2231 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            # -*- coding: utf-8 -*-
                            '''
                            Support for APT (Advanced Packaging Tool)
                            
                            .. important::
                            Severity: Major
                            Found in salt/modules/aptpkg.py - About 6 days to fix

                              File gce.py has 2185 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              # -*- coding: utf-8 -*-
                              '''
                              Copyright 2013 Google Inc. All Rights Reserved.
                              
                              Licensed under the Apache License, Version 2.0 (the "License");
                              Severity: Major
                              Found in salt/cloud/clouds/gce.py - About 6 days to fix

                                File app.py has 2181 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                # encoding: utf-8
                                '''
                                A REST API for Salt
                                ===================
                                
                                
                                Severity: Major
                                Found in salt/netapi/rest_cherrypy/app.py - About 6 days to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language