saltstack/salt

View on GitHub

Showing 9,400 of 17,590 total issues

Function convert_to_arn has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def convert_to_arn(arns, region=None, key=None, keyid=None, profile=None):
    '''
    Convert a list of strings into actual arns. Converts convenience names such
    as 'scaling_policy:...'

Severity: Minor
Found in salt/modules/boto_cloudwatch.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _execute_with_retries has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

def _execute_with_retries(conn, function, **kwargs):
    '''
    Retry if we're rate limited by AWS or blocked by another call.
    Give up and return error message if resource not found or argument is invalid.

Severity: Minor
Found in salt/modules/boto_kinesis.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                    if removed['Features'][item]['RestartNeeded']:
                        ret['RestartNeeded'] = True

        # Restart here if needed
        if restart:
Severity: Major
Found in salt/modules/win_servermanager.py - About 45 mins to fix

    Function _describe_network_interface has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def _describe_network_interface(eni):
        r = {}
        for attr in ['status', 'description', 'availability_zone', 'requesterId',
                     'requester_managed', 'mac_address', 'private_ip_address',
                     'vpc_id', 'id', 'source_dest_check', 'owner_id', 'tags',
    Severity: Minor
    Found in salt/modules/boto_ec2.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function user_exists has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def user_exists(name, database=None, user=None, password=None, host=None, port=None):
        '''
        Checks if a cluster admin or database user exists.
    
        If a database is specified: it will check for database user existence.
    Severity: Minor
    Found in salt/modules/influxdb08mod.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function refresh_db has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def refresh_db(failhard=False, **kwargs):  # pylint: disable=unused-argument
        '''
        Updates the opkg database to latest packages based upon repositories
    
        Returns a dict, with the keys being package databases and the values being
    Severity: Minor
    Found in salt/modules/opkg.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function list_employees has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def list_employees(order_by='id'):
        '''
        Show all employees for this company.
    
        CLI Example:
    Severity: Minor
    Found in salt/modules/bamboohr.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function _get_upgradable has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def _get_upgradable(backtrack=3):
        '''
        Utility function to get upgradable packages
    
        Sample return data:
    Severity: Minor
    Found in salt/modules/ebuildpkg.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function version_cmp has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

    def version_cmp(pkg1, pkg2, ignore_epoch=False, **kwargs):  # pylint: disable=unused-argument
        '''
        Do a cmp-style comparison on two packages. Return -1 if pkg1 < pkg2, 0 if
        pkg1 == pkg2, and 1 if pkg1 > pkg2. Return None if there was a problem
        making the comparison.
    Severity: Minor
    Found in salt/modules/opkg.py - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Avoid deeply nested control flow statements.
    Open

                        if not delete_tags(vol.id, remove, region=region, key=key, keyid=keyid, profile=profile):
                            ret['success'] = False
                            ret['comment'] = "Failed to remove tags on vol.id {0}: {1}".format(vol.id, remove)
                            return ret
        ret['changes'].update(changes) if changes['old'] or changes['new'] else None  # pylint: disable=W0106
    Severity: Major
    Found in salt/modules/boto_ec2.py - About 45 mins to fix

      Function attach_network_interface has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def attach_network_interface(device_index, name=None, network_interface_id=None,
                                   instance_name=None, instance_id=None,
                                   region=None, key=None, keyid=None, profile=None):
          '''
          Attach an Elastic Network Interface.
      Severity: Minor
      Found in salt/modules/boto_ec2.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function create_circuit_termination has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def create_circuit_termination(circuit, interface, device, speed, xconnect_id=None, term_side='A'):
          '''
          .. versionadded:: 2019.2.0
      
          Terminate a circuit on an interface
      Severity: Minor
      Found in salt/modules/netbox.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function _get_network_interface has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

      def _get_network_interface(conn, name=None, network_interface_id=None):
          r = {}
          if not (name or network_interface_id):
              raise SaltInvocationError(
                  'Either name or network_interface_id must be provided.'
      Severity: Minor
      Found in salt/modules/boto_ec2.py - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid deeply nested control flow statements.
      Open

                          if latest_version(param, refresh=False) == inst_v:
                              all_uses = __salt__['portage_config.get_cleared_flags'](param)
                              if _flags_changed(*all_uses):
                                  changes[param] = {'version': inst_v,
                                                    'old': {'use': all_uses[0]},
      Severity: Major
      Found in salt/modules/ebuildpkg.py - About 45 mins to fix

        Function _process_emerge_err has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        def _process_emerge_err(stdout, stderr):
            '''
            Used to parse emerge output to provide meaningful output when emerge fails
            '''
            ret = {}
        Severity: Minor
        Found in salt/modules/ebuildpkg.py - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Avoid deeply nested control flow statements.
        Open

                            if old != new:
                                changes[param + '-USE'] = {'old': old, 'new': new}
                            target = target[:target.rfind('[')]
        Severity: Major
        Found in salt/modules/ebuildpkg.py - About 45 mins to fix

          Function list_upgrades has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def list_upgrades(refresh=True, **kwargs):  # pylint: disable=unused-argument
              '''
              List all available package upgrades.
          
              CLI Example:
          Severity: Minor
          Found in salt/modules/opkg.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function detach_network_interface has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def detach_network_interface(
                  name=None, network_interface_id=None, attachment_id=None,
                  force=False, region=None, key=None, keyid=None, profile=None):
              '''
              Detach an Elastic Network Interface.
          Severity: Minor
          Found in salt/modules/boto_ec2.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function set_attribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
          Open

          def set_attribute(attribute, attribute_value, instance_name=None, instance_id=None, region=None, key=None, keyid=None,
                            profile=None, filters=None):
              '''
              Set an EC2 instance attribute.
              Returns whether the operation succeeded or not.
          Severity: Minor
          Found in salt/modules/boto_ec2.py - About 45 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid deeply nested control flow statements.
          Open

                              if verstr and verstr[0] != ':' and verstr[0] != '[':
                                  prefix = prefix or '='
                                  target = '{0}{1}-{2}'.format(prefix, param, verstr)
                              else:
                                  target = '{0}{1}'.format(param, verstr)
          Severity: Major
          Found in salt/modules/ebuildpkg.py - About 45 mins to fix
            Severity
            Category
            Status
            Source
            Language