Sign upLogin

saltstack/salt

View on GitHub
Star
salt/utils/win_dotnet.py

Summary

Maintainability
C
1 day
Test Coverage

Function versions has a Cognitive Complexity of 37 (exceeds 5 allowed). Consider refactoring.
Open

def versions():
    '''
    Figure out what versions of .NET are installed on the system

    Returns:
Severity: Minor
Found in salt/utils/win_dotnet.py - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return '4.6.1'
Severity: Major
Found in salt/utils/win_dotnet.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return '4.6'
    Severity: Major
    Found in salt/utils/win_dotnet.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return '4.5.1'
      Severity: Major
      Found in salt/utils/win_dotnet.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return '4.5.2'
        Severity: Major
        Found in salt/utils/win_dotnet.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return '4..5'
          Severity: Major
          Found in salt/utils/win_dotnet.py - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status