sds/lint-trappings

View on GitHub

Showing 11 of 11 total issues

Method add_info_options has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def add_info_options(parser)
      parser.on('--show-linters',
                'Display available linters and whether or not they are enabled') do
        @options[:command] = :display_linters
      end
Severity: Minor
Found in lib/lint_trappings/arguments_parser.rb - About 1 hr to fix

    Method add_file_options has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        def add_file_options(parser)
          parser.on('-c', '--config config-file', String,
                    'Specify which configuration file you want to use') do |conf_file|
            @options[:config_file] = conf_file
          end
    Severity: Minor
    Found in lib/lint_trappings/arguments_parser.rb - About 1 hr to fix

      Method for_consecutive_items has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def for_consecutive_items(items, satisfies, min_consecutive = 2)
            current_index = -1
      
            while (current_index += 1) < items.count
              next unless satisfies[items[current_index]]
      Severity: Minor
      Found in lib/lint_trappings/utils.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method exit_status has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.exit_status(*args)
            if args.any?
              @exit_status = args.first
            elsif @exit_status
              @exit_status
      Severity: Minor
      Found in lib/lint_trappings/errors.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method class_attribute has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def self.class_attribute(attr_name)
            # Define DSL getter/setter
            metaclass = (class << self; self; end)
            metaclass.instance_eval do
              define_method(attr_name) do |*args|
      Severity: Minor
      Found in lib/lint_trappings/application.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run_cli has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def run_cli(task_args)
            raise ArgumentError, '@application_class must be defined!' unless @application_class
      
            output = quiet ? LintTrappings::Output.silent : LintTrappings::Output.new(STDOUT)
            app = @application_class.new(output)
      Severity: Minor
      Found in lib/lint_trappings/rake_task.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method print_message has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

          def print_message(lint)
            if failing_lint?(lint)
              output.error severity_character(lint.severity), false
            elsif warning_lint?(lint)
              output.warning severity_character(lint.severity), false
      Severity: Minor
      Found in lib/lint_trappings/formatter/default.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method enabled_linter_classes has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def enabled_linter_classes
            # Include the explicit list of linters if a list was specified
            explicitly_included =
              included_linter_classes =
                linter_classes_from_names(@options.fetch(:included_linters, []))
      Severity: Minor
      Found in lib/lint_trappings/linter_selector.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method handle_exception has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def handle_exception(ex)
            if ex.is_a?(LintTrappings::LintTrappingsError) && ex.exit_status != 70
              @output.error ex.message
              ex.exit_status
            else
      Severity: Minor
      Found in lib/lint_trappings/cli.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if report.failures?
              failures = LintTrappings::Utils.pluralize('failure', report.failures.count)
              output.print ', '
              output.error "#{report.failures.count} #{failures} reported", false
      Severity: Minor
      Found in lib/lint_trappings/formatter/default.rb and 1 other location - About 20 mins to fix
      lib/lint_trappings/formatter/default.rb on lines 44..47

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            if report.warnings?
              warnings = LintTrappings::Utils.pluralize('warning', report.warnings.count)
              output.print ', '
              output.warning "#{report.warnings.count} #{warnings} reported", false
      Severity: Minor
      Found in lib/lint_trappings/formatter/default.rb and 1 other location - About 20 mins to fix
      lib/lint_trappings/formatter/default.rb on lines 38..41

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Severity
      Category
      Status
      Source
      Language