Sign upLogin

seegno/uphold-sdk-php

View on GitHub
Star

Showing 13 of 13 total issues

User has 26 functions (exceeds 20 allowed). Consider refactoring.
Open

class User extends BaseModel implements UserInterface
{
    /**
     * Country.
     *
Severity: Minor
Found in lib/Uphold/Model/User.php - About 3 hrs to fix

    UpholdClient has 24 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class UpholdClient
{
    /**
     * Uphold API urls.
     */
    Severity: Minor
    Found in lib/Uphold/UpholdClient.php - About 2 hrs to fix

      Function onRequestException has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
      Open

          protected function onRequestException(RequestException $e)
    {
        $request = $e->getRequest();
        $response = $e->getResponse();
      Severity: Minor
      Found in lib/Uphold/HttpClient/Handler/ErrorHandler.php - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function commit()
    {
        if (empty($this->origin['CardId'])) {
            throw new LogicException('Origin CardId is missing from this transaction');
        }
      Severity: Major
      Found in lib/Uphold/Model/Transaction.php and 1 other location - About 1 hr to fix
      lib/Uphold/Model/Transaction.php on lines 219..232

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          public function resend()
    {
        if (empty($this->origin['CardId'])) {
            throw new LogicException('Origin `CardId` is missing from this transaction');
        }
      Severity: Major
      Found in lib/Uphold/Model/Transaction.php and 1 other location - About 1 hr to fix
      lib/Uphold/Model/Transaction.php on lines 179..192

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 108.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Method onRequestException has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function onRequestException(RequestException $e)
    {
        $request = $e->getRequest();
        $response = $e->getResponse();
      Severity: Minor
      Found in lib/Uphold/HttpClient/Handler/ErrorHandler.php - About 1 hr to fix

        Method execute has 28 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function execute(InputInterface $input, OutputInterface $output)
    {
        // Get PAT description.
        $this->description = $this->getPATDescription();
        Severity: Minor
        Found in lib/Uphold/Command/CreateTokenCommand.php - About 1 hr to fix

          Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              public function __construct($client, $path, $parameters = array(), $headers = array(), $limit = null)
          Severity: Minor
          Found in lib/Uphold/Paginator/Paginator.php - About 35 mins to fix

            Method createTransaction has 5 arguments (exceeds 4 allowed). Consider refactoring.
            Open

                public function createTransaction($destination, $amount, $currency, $message = null, $commit = false)
            Severity: Minor
            Found in lib/Uphold/Model/Card.php - About 35 mins to fix

              Method request has 5 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                  public function request($path, $body, $httpMethod = 'GET', array $headers = array(), array $options = array())
              Severity: Minor
              Found in lib/Uphold/HttpClient/HttpClient.php - About 35 mins to fix

                Method __construct has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                    public function __construct($message, $error = null, $httpCode = null, $response = null, $request = null)
                Severity: Minor
                Found in lib/Uphold/Exception/UpholdClientException.php - About 35 mins to fix

                  Function execute has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
                  Open

                      protected function execute(InputInterface $input, OutputInterface $output)
    {
        // Get PAT description.
        $this->description = $this->getPATDescription();
                  Severity: Minor
                  Found in lib/Uphold/Command/CreateTokenCommand.php - About 35 mins to fix

                  Cognitive Complexity

                  Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                  A method's cognitive complexity is based on a few simple rules:

                  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                  • Code is considered more complex for each "break in the linear flow of the code"
                  • Code is considered more complex when "flow breaking structures are nested"

                  Further reading

                  Avoid too many return statements within this method.
                  Open

                          return 'An unknown error occurred';
                  Severity: Major
                  Found in lib/Uphold/HttpClient/Message/Response.php - About 30 mins to fix
                    Severity
                    Category
                    Status
                    Source
                    Language