Sign upLogin

senecajs/seneca-mongo-store

View on GitHub
Star

Showing 9 of 9 total issues

Function mongo_store has a Cognitive Complexity of 66 (exceeds 5 allowed). Consider refactoring.
Open

const mongo_store = function mongo_store(options) {
  const seneca = this
  let desc

  let dbinst = null
Severity: Minor
Found in mongo-store.js - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function metaquery has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

function metaquery(q) {
  let mq = {}

  if (!q.native$) {
    if (q.sort$) {
Severity: Minor
Found in lib/intern.js - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function fixquery has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

function fixquery(q, seneca, options) {
  if (q.native$) {
    return  Array.isArray(q.native$) ? q.native$[0] : q.native$
  }
Severity: Minor
Found in lib/intern.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

            (err, update) => {
              if (error(msg, err, done)) {
                return
              }
Severity: Minor
Found in mongo-store.js and 1 other location - About 55 mins to fix
mongo-store.js on lines 212..221

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

          function (err, update) {
            if (error(msg, err, done)) {
              return
            }
Severity: Minor
Found in mongo-store.js and 1 other location - About 55 mins to fix
mongo-store.js on lines 153..162

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 53.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Avoid deeply nested control flow statements.
Open

                    if (entp) {
                      let fent = null
                      if (entp) {
                        toDelete.push(entp._id)
                        entp.id = intern.idstr(entp._id)
Severity: Major
Found in mongo-store.js - About 45 mins to fix

    Function finalizeSave has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

          function finalizeSave(operation_name, doc, ent, seneca, done) {
    Severity: Minor
    Found in mongo-store.js - About 35 mins to fix

      Avoid too many return statements within this function.
      Open

          return { _id: makeid(q.id) }
      Severity: Major
      Found in lib/intern.js - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

          return qq
        Severity: Major
        Found in lib/intern.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language