Sign upLogin

senecajs/seneca

View on GitHub
Star
lib/act.ts

Summary

Maintainability
C
1 day
Test Coverage

Function do_act has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

  do_act: function(instance: any, opts: any, origmsg: any, origreply: any) {
    let timedout = false
    const actmsg = intern.make_actmsg(origmsg)
    const meta = new Meta(instance, opts, origmsg, origreply)
Severity: Minor
Found in lib/act.ts - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_inward_break has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  handle_inward_break: function(
    inward: any,
    act_instance: any,
    data: any,
    actdef: any,
Severity: Minor
Found in lib/act.ts - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function handle_reply has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    opts: any,
    meta: any,
    actctxt: any,
    actmsg: any,
    err: any,
Severity: Major
Found in lib/act.ts - About 50 mins to fix

    Function execute_action has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        execspec: any,
    act_instance: any,
    opts: any,
    actctxt: any,
    msg: any,
    Severity: Major
    Found in lib/act.ts - About 50 mins to fix

      Function handle_reply has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

        handle_reply: function(
    opts: any,
    meta: any,
    actctxt: any,
    actmsg: any,
      Severity: Minor
      Found in lib/act.ts - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function handle_inward_break has 5 arguments (exceeds 4 allowed). Consider refactoring.
      Open

          inward: any,
    act_instance: any,
    data: any,
    actdef: any,
    origmsg: any
      Severity: Minor
      Found in lib/act.ts - About 35 mins to fix

        Function execute_action has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
        Open

          execute_action: function(
    execspec: any,
    act_instance: any,
    opts: any,
    actctxt: any,
        Severity: Minor
        Found in lib/act.ts - About 35 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Function process_outward has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          process_outward: function(actctxt: any, data: any) {
    const act_instance = actctxt.seneca
    const outwardres = act_instance.order.outward.execSync(actctxt, data)

    if (outwardres.err) {
        Severity: Minor
        Found in lib/act.ts - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

        const ActArgu: any = Argu('act', {
  props: One(Empty(String), Object),
  moreprops: Skip(Object),
  reply: Skip(Function),
})
        Severity: Minor
        Found in lib/act.ts and 1 other location - About 40 mins to fix
        lib/prior.ts on lines 24..28

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status