sensu-plugins/sensu-plugins-dns

View on GitHub

Showing 8 of 12 total issues

Method check_results has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  def check_results(entries)
    errors = []
    success = []

    # TODO: come back and refactor
Severity: Minor
Found in bin/check-dns.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method check_results has 43 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def check_results(entries)
    errors = []
    success = []

    # TODO: come back and refactor
Severity: Minor
Found in bin/check-dns.rb - About 1 hr to fix

    Method resolve_domain has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def resolve_domain(server)
        dnsruby_config = {}
    
        dnsruby_config[:nameserver] = server unless server.nil?
        dnsruby_config[:port] = config[:port] unless config[:port].nil?
    Severity: Minor
    Found in bin/check-dns.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method soa_query has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def soa_query(entries)
        errors = []
        success = []
        resp = ::Resolv::DNS.new.getresources(config[:domain], Resolv::DNS::Resource::IN::SOA)
        primary_serial_number = resp.map(&:serial).first
    Severity: Minor
    Found in bin/check-dns-zone.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          unknown 'No domain specified' if config[:domain].nil?
          unknown 'Count must be 1 or more' if config[:request_count] < 1
      
          success = []
      Severity: Minor
      Found in bin/check-dns.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_dns_connection has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_dns_connection(entries, use_tcp = false)
          errors = []
          success = []
      
          entries.each do |ns|
      Severity: Minor
      Found in bin/check-dns-zone.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          unknown 'No domain specified' if config[:domain].nil?
      
          begin
            dnsruby_config = {}
      Severity: Minor
      Found in bin/metrics-dns.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
          unknown 'No domain specified' if config[:domain].nil?
      
          entries = resolve_ns
          errors, success = check_results(entries)
      Severity: Minor
      Found in bin/check-dns-zone.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language