sensu-plugins/sensu-plugins-elasticsearch

View on GitHub

Showing 69 of 69 total issues

Method kibana_info has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  def kibana_info
    kibana_date_format = '%Y-%m-%dT%H:%M:%S.%LZ'
    unless config[:kibana_url].nil?
      index = config[:index]
      unless config[:date_index].nil?
Severity: Minor
Found in bin/check-es-query-average.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 44 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    dividend_query = config[:dividend]
    divisor_query = config[:divisor]
    config.delete(:dividend)
    config.delete(:divisor)
Severity: Minor
Found in bin/check-es-query-ratio.rb - About 1 hr to fix

    Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        if !config[:master_only] || master?
          case acquire_status
          when 'green'
            ok 'Cluster is green'
    Severity: Minor
    Found in bin/check-es-cluster-status.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method es_date_math_string has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def es_date_math_string(end_time)
        if config[:minutes_previous].zero? && \
           config[:hours_previous].zero? && \
           config[:days_previous].zero? && \
           config[:weeks_previous].zero? && \
    Severity: Minor
    Found in lib/sensu-plugins-elasticsearch/elasticsearch-query.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
        options = {}
        unless config[:level].nil?
          options[:level] = config[:level]
        end
    Severity: Minor
    Found in bin/check-es-cluster-health.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        elsif response['aggregations']['average']['value'] > config[:crit]
          critical "Query average (#{response['aggregations']['average']['value']}) was above critical threshold. #{kibana_info}"
        elsif response['aggregations']['average']['value'] > config[:warn]
          warning "Query average (#{response['aggregations']['average']['value']}) was above warning threshold. #{kibana_info}"
        else
    Severity: Major
    Found in bin/check-es-query-average.rb and 2 other locations - About 1 hr to fix
    bin/check-es-query-average.rb on lines 260..266
    bin/check-es-query-average.rb on lines 276..282

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          if response['aggregations']['average']['value'] < config[:crit]
            critical "Query average (#{response['aggregations']['average']['value']}) was below critical threshold. #{kibana_info}"
          elsif response['aggregations']['average']['value'] < config[:warn]
            warning "Query average (#{response['aggregations']['average']['value']}) was below warning threshold. #{kibana_info}"
          else
    Severity: Major
    Found in bin/check-es-query-average.rb and 2 other locations - About 1 hr to fix
    bin/check-es-query-average.rb on lines 260..266
    bin/check-es-query-average.rb on lines 267..273

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

          if response['aggregations']['average']['value'] < config[:crit]
            critical "Query average (#{response['aggregations']['average']['value']}) was below critical threshold. #{kibana_info}"
          elsif response['aggregations']['average']['value'] < config[:warn]
            warning "Query average (#{response['aggregations']['average']['value']}) was below warning threshold. #{kibana_info}"
          else
    Severity: Major
    Found in bin/check-es-query-average.rb and 2 other locations - About 1 hr to fix
    bin/check-es-query-average.rb on lines 267..273
    bin/check-es-query-average.rb on lines 276..282

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 61.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method build_request_options has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def build_request_options
        end_time = (Time.now.utc - config[:offset])
        options = {
    
          index: indices(end_time),
    Severity: Minor
    Found in lib/sensu-plugins-elasticsearch/elasticsearch-query.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_indices_with_sizes has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def build_indices_with_sizes
        indices_fs_stats = client.indices.stats store: true
        pattern_regex = Regexp.new(config[:pattern_regex])
    
        index_with_sizes = indices_fs_stats['indices'].keys.each_with_object({}) do |key, hash|
    Severity: Minor
    Found in bin/check-es-indices-sizes.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method indices has 34 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def indices(end_time)
        if !config[:index].nil?
          return config[:index]
        elsif !config[:date_index].nil?
          indices = []
    Severity: Minor
    Found in lib/sensu-plugins-elasticsearch/elasticsearch-query.rb - About 1 hr to fix

      Method kibana_info has 32 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def kibana_info
          kibana_date_format = '%Y-%m-%dT%H:%M:%S.%LZ'
          unless config[:kibana_url].nil?
            index = config[:index]
            unless config[:date_index].nil?
      Severity: Minor
      Found in bin/check-es-query-ratio.rb - About 1 hr to fix

        Method kibana_info has 32 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def kibana_info
            kibana_date_format = '%Y-%m-%dT%H:%M:%S.%LZ'
            unless config[:kibana_url].nil?
              index = config[:index]
              unless config[:date_index].nil?
        Severity: Minor
        Found in bin/check-es-query-average.rb - About 1 hr to fix

          Method kibana_info has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def kibana_info
              kibana_date_format = '%Y-%m-%dT%H:%M:%S.%LZ'
              unless config[:kibana_url].nil?
                index = config[:index]
                unless config[:date_index].nil?
          Severity: Minor
          Found in bin/check-es-query-count.rb - About 1 hr to fix

            Method run has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              def run
                if client.exists?(build_request_options)
                  if config[:invert]
                    if config[:warn]
                      warning
            Severity: Minor
            Found in bin/check-es-query-exists.rb - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              rescue Elasticsearch::Transport::Transport::Errors::NotFound
                if config[:invert]
                  if response['count'] < config[:crit]
                    critical "Query count (#{response['count']}) was below critical threshold. #{kibana_info}"
                  elsif response['count'] < config[:warn]
            Severity: Major
            Found in bin/check-es-query-count.rb and 1 other location - About 1 hr to fix
            bin/check-es-query-ratio.rb on lines 293..303

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Identical blocks of code found in 2 locations. Consider refactoring.
            Open

              rescue Elasticsearch::Transport::Transport::Errors::NotFound
                if config[:invert]
                  if response['count'] < config[:crit]
                    critical "Query count (#{response['count']}) was below critical threshold. #{kibana_info}"
                  elsif response['count'] < config[:warn]
            Severity: Major
            Found in bin/check-es-query-ratio.rb and 1 other location - About 1 hr to fix
            bin/check-es-query-count.rb on lines 262..272

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 54.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def run
                options = {}
                unless config[:level].nil?
                  options[:level] = config[:level]
                end
            Severity: Minor
            Found in bin/check-es-cluster-health.rb - About 1 hr to fix

              Method acquire_es_resource has 29 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def acquire_es_resource(resource)
                  headers = {}
                  if config[:user] && config[:password]
                    auth = 'Basic ' + Base64.strict_encode64("#{config[:user]}:#{config[:password]}").chomp
                    headers = { 'Authorization' => auth }
              Severity: Minor
              Found in bin/check-es-heap.rb - About 1 hr to fix

                Method get_es_resource has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def get_es_resource(resource)
                    headers = {}
                    if config[:user] && config[:password]
                      auth = 'Basic ' + Base64.strict_encode64("#{config[:user]}:#{config[:password]}").chomp
                      headers = { 'Authorization' => auth }
                Severity: Minor
                Found in bin/check-es-cluster-status.rb - About 1 hr to fix
                  Severity
                  Category
                  Status
                  Source
                  Language