Sign upLogin

sensu-plugins/sensu-plugins-environmental-checks

View on GitHub
Star

Showing 4 of 4 total issues

Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    raw = `sensors`
    sections = raw.split("\n\n")
    metrics = {}
    sections.each do |section|
Severity: Minor
Found in bin/check-temperature.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    raw = `sensors`
    sections = raw.split("\n\n")
    metrics = {}
    sections.each do |section|
Severity: Minor
Found in bin/check-temperature.rb - About 1 hr to fix

    Method run has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    raw = `sensors -A`
    sections = raw.split("\n\n")
    metrics = {}
    Severity: Minor
    Found in bin/metrics-temperature.rb - About 1 hr to fix

      Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    raw = `sensors -A`
    sections = raw.split("\n\n")
    metrics = {}
      Severity: Minor
      Found in bin/metrics-temperature.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language