sensu-plugins/sensu-plugins-etcd

View on GitHub

Showing 9 of 11 total issues

Method run has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if config[:allmembers]
      members = JSON.parse(request('/v2/members', config[:server]).to_str)['members']
      bad_peers = []
      members.each do |member|
Severity: Minor
Found in bin/check-etcd.rb - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    protocol = config[:ssl] ? 'https' : 'http'
    r = RestClient::Resource.new("#{protocol}://#{config[:server]}:#{config[:port]}/v2/members",
                                 timeout: 5,
                                 ssl_client_cert: (OpenSSL::X509::Certificate.new(File.read(config[:cert])) unless config[:cert].nil?),
Severity: Minor
Found in bin/check-etcd-peer-count.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if config[:ssl]
      client = Etcd.client(
        host: config[:etcd_host],
        port: config[:etcd_port],
Severity: Minor
Found in bin/metrics-etcd.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    if config[:allmembers]
      members = JSON.parse(request('/v2/members', config[:server]).to_str)['members']
      bad_peers = []
      members.each do |member|
Severity: Minor
Found in bin/check-etcd.rb - About 1 hr to fix

    Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        if config[:ssl]
          client = Etcd.client(
            host: config[:etcd_host],
            port: config[:etcd_port],
    Severity: Minor
    Found in bin/metrics-etcd.rb - About 1 hr to fix

      Method run has 27 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
          begin # Get the network configuration
            flannel_config = request('v2/keys/coreos.com/network/config', config[:server])
            # The value is stored as a json string within the json, so we have to parse, pull out the string and re-parse...
            num_address = JSON.parse(JSON.parse(flannel_config.to_str)['node']['value'])['Network']
      Severity: Minor
      Found in bin/check-flannel-subnet-count.rb - About 1 hr to fix

        Method request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def request(path, server)
            protocol = config[:ssl] ? 'https' : 'http'
            RestClient::Resource.new("#{protocol}://#{server}:#{config[:port]}/#{path}",
                                     timeout: 5,
                                     ssl_client_cert: (OpenSSL::X509::Certificate.new(File.read(config[:cert])) unless config[:cert].nil?),
        Severity: Minor
        Found in bin/check-etcd.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

          def request(path, server)
            protocol = config[:ssl] ? 'https' : 'http'
            RestClient::Resource.new(
              "#{protocol}://#{server}:#{config[:port]}/#{path}",
              timeout: 5,
        Severity: Minor
        Found in bin/check-flannel-subnet-count.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
            begin # Get the network configuration
              flannel_config = request('v2/keys/coreos.com/network/config', config[:server])
              # The value is stored as a json string within the json, so we have to parse, pull out the string and re-parse...
              num_address = JSON.parse(JSON.parse(flannel_config.to_str)['node']['value'])['Network']
        Severity: Minor
        Found in bin/check-flannel-subnet-count.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language