sensu-plugins/sensu-plugins-graphite

View on GitHub
bin/check-graphite.rb

Summary

Maintainability
F
6 days
Test Coverage

File check-graphite.rb has 444 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'sensu-plugin/check/cli'
require 'json'
require 'net/http'
require 'net/https'
require 'socket'
Severity: Minor
Found in bin/check-graphite.rb - About 6 hrs to fix

    Method check_average_percent has a Cognitive Complexity of 40 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_average_percent(target, max_values, data_points = 1)
        values = get_graphite_values target
        last_values = last_graphite_value(target, data_points)
        return [[], [], []] unless values
        warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 6 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
    Open

      def run # rubocop:disable AbcSize
        targets = config[:complex_target] ? [config[:target]] : config[:target].split(',')
        @period = config[:period]
        critical_errors = []
        warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_percentile has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_percentile(target, max_values, percentile, data_points = 1)
        values = get_graphite_values target
        last_values = last_graphite_value(target, data_points)
        return [[], [], []] unless values
        warnings = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_average has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_average(target, max_values)
        values = get_graphite_values target
        return [[], [], []] unless values
        warnings = []
        criticals = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method check_last has a Cognitive Complexity of 36 (exceeds 5 allowed). Consider refactoring.
    Open

      def check_last(target, max_values)
        last_targets = last_graphite_value target
        return [[], [], []] unless last_targets
        warnings = []
        criticals = []
    Severity: Minor
    Found in bin/check-graphite.rb - About 5 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 57 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run # rubocop:disable AbcSize
        targets = config[:complex_target] ? [config[:target]] : config[:target].split(',')
        @period = config[:period]
        critical_errors = []
        warnings = []
    Severity: Major
    Found in bin/check-graphite.rb - About 2 hrs to fix

      Method get_last_metric has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
      Open

        def get_last_metric(values, count = 1)
          if values
            ret = []
            values_size = values.size
            count = values_size if count > values_size
      Severity: Minor
      Found in bin/check-graphite.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_increasing has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
      Open

        def check_increasing(target)
          updated_since = config[:updated_since].to_i
          time_to_be_updated_since = Time.now - updated_since
          critical_errors = []
          warnings = []
      Severity: Minor
      Found in bin/check-graphite.rb - About 1 hr to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method check_percentile has 35 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def check_percentile(target, max_values, percentile, data_points = 1)
          values = get_graphite_values target
          last_values = last_graphite_value(target, data_points)
          return [[], [], []] unless values
          warnings = []
      Severity: Minor
      Found in bin/check-graphite.rb - About 1 hr to fix

        Method check_average_percent has 35 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def check_average_percent(target, max_values, data_points = 1)
            values = get_graphite_values target
            last_values = last_graphite_value(target, data_points)
            return [[], [], []] unless values
            warnings = []
        Severity: Minor
        Found in bin/check-graphite.rb - About 1 hr to fix

          Method check_average has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def check_average(target, max_values)
              values = get_graphite_values target
              return [[], [], []] unless values
              warnings = []
              criticals = []
          Severity: Minor
          Found in bin/check-graphite.rb - About 1 hr to fix

            Method check_last has 30 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def check_last(target, max_values)
                last_targets = last_graphite_value target
                return [[], [], []] unless last_targets
                warnings = []
                criticals = []
            Severity: Minor
            Found in bin/check-graphite.rb - About 1 hr to fix

              Method been_updated_since has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

                def been_updated_since(target, time, updated_since)
                  last_time_stamp = last_graphite_metric target
                  warnings = []
                  if last_time_stamp
                    last_time_stamp.each do |target_name, value|
              Severity: Minor
              Found in bin/check-graphite.rb - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                          text = "The metric #{target_name} is #{last_value} that is #{greater_less} than last allowed #{max_value}"
                          case type
                          when 'warning'
                            warnings << text
                          when 'error'
              Severity: Minor
              Found in bin/check-graphite.rb and 1 other location - About 50 mins to fix
              bin/check-graphite.rb on lines 378..389

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                        text = "The average value of metric #{target} is #{avg_value} that is #{greater_less} than allowed average of #{max_value}"
                        case type
                        when 'warning'
                          warnings << text
                        when 'error'
              Severity: Minor
              Found in bin/check-graphite.rb and 1 other location - About 50 mins to fix
              bin/check-graphite.rb on lines 452..463

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 43.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if config[:check_average]
                      max_values = get_levels config[:check_average]
                      avg_warnings, avg_critical, avg_fatal = check_average(target, max_values)
                      warnings += avg_warnings
                      critical_errors += avg_critical
              Severity: Minor
              Found in bin/check-graphite.rb and 1 other location - About 25 mins to fix
              bin/check-graphite.rb on lines 485..491

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                    if config[:check_last]
                      max_values = get_levels config[:check_last]
                      lt_warnings, lt_critical, lt_fatal = check_last(target, max_values)
                      warnings += lt_warnings
                      critical_errors += lt_critical
              Severity: Minor
              Found in bin/check-graphite.rb and 1 other location - About 25 mins to fix
              bin/check-graphite.rb on lines 492..498

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 31.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status