sensu-plugins/sensu-plugins-mailer

View on GitHub

Showing 7 of 11 total issues

Method build_mail_to_list has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
Open

  def build_mail_to_list
    mail_to = Set.new
    mail_to.add(@event['client']['mail_to'] || json_config_settings['mail_to'])
    if json_config_settings.key?('subscriptions') && @event['check']['subscribers']
      @event['check']['subscribers'].each do |sub|
Severity: Minor
Found in bin/handler-mailer.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method handle has 59 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def handle
    body = build_body
    subject = "#{prefix_subject}#{build_subject}"

    content_type = parse_content_type
Severity: Major
Found in bin/handler-mailer.rb - About 2 hrs to fix

    Method handle has 37 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def handle
        params = {
          mail_to: settings[json_config]['mail_to'],
          mail_from: settings[json_config]['mail_from'],
          aws_access_key: settings[json_config]['aws_access_key'],
    Severity: Minor
    Found in bin/handler-mailer-ses.rb - About 1 hr to fix

      Method handle has 33 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def handle
          params = {
            mail_to: settings[json_config]['mail_to'],
            mail_from: settings[json_config]['mail_from'],
            mg_apikey: settings[json_config]['mg_apikey'],
      Severity: Minor
      Found in bin/handler-mailer-mailgun.rb - About 1 hr to fix

        Method build_mail_to_list has 30 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def build_mail_to_list
            mail_to = Set.new
            mail_to.add(@event['client']['mail_to'] || json_config_settings['mail_to'])
            if json_config_settings.key?('subscriptions') && @event['check']['subscribers']
              @event['check']['subscribers'].each do |sub|
        Severity: Minor
        Found in bin/handler-mailer.rb - About 1 hr to fix

          Method handle has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
          Open

            def handle
              body = build_body
              subject = "#{prefix_subject}#{build_subject}"
          
              content_type = parse_content_type
          Severity: Minor
          Found in bin/handler-mailer.rb - About 35 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method parse_content_type has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
          Open

            def parse_content_type
              use = if config[:content_type]
                      config[:content_type]
                    elsif @event['check']['content_type']
                      @event['check']['content_type']
          Severity: Minor
          Found in bin/handler-mailer.rb - About 25 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Severity
          Category
          Status
          Source
          Language