Sign upLogin

sensu-plugins/sensu-plugins-mysql

View on GitHub
Star
bin/check-mysql-replication-status.rb

Summary

Maintainability
C
7 hrs
Test Coverage

Method run has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
Severity: Minor
Found in bin/check-mysql-replication-status.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
Severity: Major
Found in bin/check-mysql-replication-status.rb - About 2 hrs to fix

    Similar blocks of code found in 13 locations. Consider refactoring.
    Open

        if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      db_pass = section['password']
    Severity: Major
    Found in bin/check-mysql-replication-status.rb and 12 other locations - About 35 mins to fix
    bin/check-mysql-alive.rb on lines 84..91
    bin/check-mysql-connections.rb on lines 77..84
    bin/check-mysql-disk.rb on lines 80..87
    bin/check-mysql-innodb-lock.rb on lines 71..78
    bin/check-mysql-msr-replication-status.rb on lines 90..97
    bin/check-mysql-query-result-count.rb on lines 85..92
    bin/check-mysql-threads.rb on lines 103..110
    bin/metrics-mysql-graphite.rb on lines 215..222
    bin/metrics-mysql-multiple-select-count.rb on lines 79..86
    bin/metrics-mysql-processes.rb on lines 108..115
    bin/metrics-mysql-query-result-count.rb on lines 77..84
    bin/metrics-mysql-select-count.rb on lines 77..84

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 34.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 7 locations. Consider refactoring.
    Open

        rescue Mysql::Error => e
      errstr = "Error code: #{e.errno} Error message: #{e.error}"
      critical "#{errstr} SQLSTATE: #{e.sqlstate}" if e.respond_to?('sqlstate')
    rescue StandardError => e
      critical e
    Severity: Major
    Found in bin/check-mysql-replication-status.rb and 6 other locations - About 20 mins to fix
    bin/check-mysql-disk.rb on lines 128..133
    bin/check-mysql-query-result-count.rb on lines 104..109
    bin/check-mysql-select-count.rb on lines 107..112
    bin/metrics-mysql-multiple-select-count.rb on lines 106..111
    bin/metrics-mysql-query-result-count.rb on lines 91..96
    bin/metrics-mysql-select-count.rb on lines 93..98

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    There are no issues that match your filters.

    Category
    Status