Sign upLogin

sensu-plugins/sensu-plugins-mysql

View on GitHub
Star
bin/metrics-mysql-graphite.rb

Summary

Maintainability
D
1 day
Test Coverage

Method metrics_hash has 109 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def metrics_hash
    {
      'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
Severity: Major
Found in bin/metrics-mysql-graphite.rb - About 4 hrs to fix

    Method run has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

      def run
    # props to https://github.com/coredump/hoardd/blob/master/scripts-available/mysql.coffee

    metrics = metrics_hash
    Severity: Minor
    Found in bin/metrics-mysql-graphite.rb - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method run has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
    # props to https://github.com/coredump/hoardd/blob/master/scripts-available/mysql.coffee

    metrics = metrics_hash
    Severity: Major
    Found in bin/metrics-mysql-graphite.rb - About 2 hrs to fix

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            'commands' => {
        'Com_admin_commands' => 'admin_commands',
        'Com_begin' => 'begin',
        'Com_change_db' => 'change_db',
        'Com_commit' => 'commit',
      Severity: Major
      Found in bin/metrics-mysql-graphite.rb and 1 other location - About 1 hr to fix
      bin/metrics-mysql-raw.rb on lines 197..230

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 67.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
        'Key_read_requests' => 'keyRead_requests',
        'Key_reads' => 'keyReads',
      Severity: Minor
      Found in bin/metrics-mysql-graphite.rb and 1 other location - About 1 hr to fix
      bin/metrics-mysql-raw.rb on lines 164..187

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 47.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            'innodb' => {
        'Innodb_buffer_pool_pages_total' => 'bufferTotal_pages',
        'Innodb_buffer_pool_pages_free' => 'bufferFree_pages',
        'Innodb_buffer_pool_pages_dirty' => 'bufferDirty_pages',
        'Innodb_buffer_pool_pages_data' => 'bufferUsed_pages',
      Severity: Minor
      Found in bin/metrics-mysql-graphite.rb and 1 other location - About 45 mins to fix
      bin/metrics-mysql-raw.rb on lines 247..266

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 39.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

              slave_results.fetch_hash.each_pair do |key, value|
          if metrics['general'].include?(key)
            # Replication lag being null is bad, very bad, so negativate it here
            value = -1 if key == 'Seconds_Behind_Master' && value.nil?
            output "#{config[:scheme]}.#{mysql_shorthostname}.general.#{metrics['general'][key]}", value
      Severity: Minor
      Found in bin/metrics-mysql-graphite.rb and 1 other location - About 40 mins to fix
      bin/metrics-mysql-raw.rb on lines 297..301

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 13 locations. Consider refactoring.
      Open

            if config[:ini]
        ini = IniFile.load(config[:ini])
        section = ini[config[:ini_section]]
        db_user = section['user']
        db_pass = section['password']
      Severity: Major
      Found in bin/metrics-mysql-graphite.rb and 12 other locations - About 35 mins to fix
      bin/check-mysql-alive.rb on lines 84..91
      bin/check-mysql-connections.rb on lines 77..84
      bin/check-mysql-disk.rb on lines 80..87
      bin/check-mysql-innodb-lock.rb on lines 71..78
      bin/check-mysql-msr-replication-status.rb on lines 90..97
      bin/check-mysql-query-result-count.rb on lines 85..92
      bin/check-mysql-replication-status.rb on lines 117..124
      bin/check-mysql-threads.rb on lines 103..110
      bin/metrics-mysql-multiple-select-count.rb on lines 79..86
      bin/metrics-mysql-processes.rb on lines 108..115
      bin/metrics-mysql-query-result-count.rb on lines 77..84
      bin/metrics-mysql-select-count.rb on lines 77..84

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 34.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

            'counters' => {
        'Handler_write' => 'handlerWrite',
        'Handler_update' => 'handlerUpdate',
        'Handler_delete' => 'handlerDelete',
        'Handler_read_first' => 'handlerRead_first',
      Severity: Minor
      Found in bin/metrics-mysql-graphite.rb and 1 other location - About 20 mins to fix
      bin/metrics-mysql-raw.rb on lines 232..245

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 27.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status