sensu-plugins/sensu-plugins-mysql

View on GitHub
bin/metrics-mysql-raw.rb

Summary

Maintainability
D
3 days
Test Coverage

Method metrics_hash has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def metrics_hash
    metrics = {
      'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
Severity: Major
Found in bin/metrics-mysql-raw.rb - About 4 hrs to fix

    File metrics-mysql-raw.rb has 324 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'sensu-plugin/metric/cli'
    require 'open3'
    require 'socket'
    require 'inifile'
    require 'timeout'
    Severity: Minor
    Found in bin/metrics-mysql-raw.rb - About 3 hrs to fix

      Method fetcher has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
      Open

        def fetcher(db_user, db_pass, db_socket)
          metrics = metrics_hash
          # FIXME: this needs refactoring
          if config[:check] == 'metric' # rubocop:disable Style/GuardClause
            mysql_shorthostname = config[:hostname].tr('.', '_')
      Severity: Minor
      Found in bin/metrics-mysql-raw.rb - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method fetcher has 40 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def fetcher(db_user, db_pass, db_socket)
          metrics = metrics_hash
          # FIXME: this needs refactoring
          if config[:check] == 'metric' # rubocop:disable Style/GuardClause
            mysql_shorthostname = config[:hostname].tr('.', '_')
      Severity: Minor
      Found in bin/metrics-mysql-raw.rb - About 1 hr to fix

        Method configuration_metrics has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
        Open

          def configuration_metrics(metrics, db_user, db_pass, db_socket)
            mysql_shorthostname = config[:hostname].tr('.', '_')
            table = []
            cmd = "#{config[:binary]} -u #{db_user} -h #{config[:hostname]} \
        --port #{config[:port]} --socket #{db_socket} -p\"#{db_pass.chomp}\" --batch \
        Severity: Minor
        Found in bin/metrics-mysql-raw.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method slave_metrics has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
        Open

          def slave_metrics(metrics)
            # should return a single element array containing one hash
            # #YELLOW
            mysql_shorthostname = config[:hostname].tr('.', '_')
            slave_results = Hash['a' => 100, 'b' => 200]
        Severity: Minor
        Found in bin/metrics-mysql-raw.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method configuration_metrics has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def configuration_metrics(metrics, db_user, db_pass, db_socket)
            mysql_shorthostname = config[:hostname].tr('.', '_')
            table = []
            cmd = "#{config[:binary]} -u #{db_user} -h #{config[:hostname]} \
        --port #{config[:port]} --socket #{db_socket} -p\"#{db_pass.chomp}\" --batch \
        Severity: Minor
        Found in bin/metrics-mysql-raw.rb - About 1 hr to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                'commands' => {
                  'Com_admin_commands' => 'admin_commands',
                  'Com_begin' => 'begin',
                  'Com_change_db' => 'change_db',
                  'Com_commit' => 'commit',
          Severity: Major
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
          bin/metrics-mysql-graphite.rb on lines 129..162

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 67.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              stdout, _stderr, status = Open3.capture3(cmd)
              puts status.to_s.split(' ')[3] if config[:verbose]
              if status == 0
                puts status.to_s if config[:verbose]
                stdout.split("\n").each do |row|
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
          bin/metrics-mysql-raw.rb on lines 350..359

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

          --port #{config[:port]} --socket #{db_socket} -p\"#{db_pass.chomp}\" --batch \
          --disable-column-names -e 'SHOW GLOBAL STATUS;'"
                  stdout, _stderr, status = Open3.capture3(cmd)
                  puts status.to_s.split(' ')[3] if config[:verbose]
                  if status == 0
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
          bin/metrics-mysql-raw.rb on lines 315..324

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                'general' => {
                  'Bytes_received' => 'rxBytes',
                  'Bytes_sent' => 'txBytes',
                  'Key_read_requests' => 'keyRead_requests',
                  'Key_reads' => 'keyReads',
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 1 hr to fix
          bin/metrics-mysql-graphite.rb on lines 97..120

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 47.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                'innodb' => {
                  'Innodb_buffer_pool_pages_total' => 'bufferTotal_pages',
                  'Innodb_buffer_pool_pages_free' => 'bufferFree_pages',
                  'Innodb_buffer_pool_pages_dirty' => 'bufferDirty_pages',
                  'Innodb_buffer_pool_pages_data' => 'bufferUsed_pages',
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 45 mins to fix
          bin/metrics-mysql-graphite.rb on lines 179..198

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 39.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              slave_results.first.each do |key, value|
                if metrics['general'].include?(key)
                  # Replication lag being null is bad, very bad, so negativate it here
                  value = -1 if key == 'Seconds_Behind_Master' && value.nil?
                  output "#{config[:scheme]}.#{mysql_shorthostname}.general.#{metrics['general'][key]}", value
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 40 mins to fix
          bin/metrics-mysql-graphite.rb on lines 244..248

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 38.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

                begin
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 3 other locations - About 20 mins to fix
          bin/check-mysql-status.rb on lines 137..137
          bin/check-mysql-status.rb on lines 155..155
          bin/metrics-mysql-raw.rb on lines 312..312

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

                'counters' => {
                  'Handler_write' => 'handlerWrite',
                  'Handler_update' => 'handlerUpdate',
                  'Handler_delete' => 'handlerDelete',
                  'Handler_read_first' => 'handlerRead_first',
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 1 other location - About 20 mins to fix
          bin/metrics-mysql-graphite.rb on lines 164..177

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 4 locations. Consider refactoring.
          Open

              cmd = "#{config[:binary]} -u #{db_user} -h #{config[:hostname]} \
          Severity: Minor
          Found in bin/metrics-mysql-raw.rb and 3 other locations - About 20 mins to fix
          bin/check-mysql-status.rb on lines 137..137
          bin/check-mysql-status.rb on lines 155..155
          bin/metrics-mysql-raw.rb on lines 347..347

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 27.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status