Sign upLogin

sensu-plugins/sensu-plugins-mysql

View on GitHub
Star

Showing 30 of 66 total issues

Method metrics_hash has 110 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def metrics_hash
    metrics = {
      'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
Severity: Major
Found in bin/metrics-mysql-raw.rb - About 4 hrs to fix

    Method metrics_hash has 109 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def metrics_hash
    {
      'general' => {
        'Bytes_received' => 'rxBytes',
        'Bytes_sent' => 'txBytes',
    Severity: Major
    Found in bin/metrics-mysql-graphite.rb - About 4 hrs to fix

      Method run has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
      Severity: Minor
      Found in bin/check-mysql-replication-status.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method run has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
      Open

        def run
    # props to https://github.com/coredump/hoardd/blob/master/scripts-available/mysql.coffee

    metrics = metrics_hash
      Severity: Minor
      Found in bin/metrics-mysql-graphite.rb - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File metrics-mysql-raw.rb has 324 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'sensu-plugin/metric/cli'
require 'open3'
require 'socket'
require 'inifile'
require 'timeout'
      Severity: Minor
      Found in bin/metrics-mysql-raw.rb - About 3 hrs to fix

        Method fetcher has a Cognitive Complexity of 23 (exceeds 5 allowed). Consider refactoring.
        Open

          def fetcher(db_user, db_pass, db_socket)
    metrics = metrics_hash
    # FIXME: this needs refactoring
    if config[:check] == 'metric' # rubocop:disable Style/GuardClause
      mysql_shorthostname = config[:hostname].tr('.', '_')
        Severity: Minor
        Found in bin/metrics-mysql-raw.rb - About 3 hrs to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method run has 74 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
        Severity: Major
        Found in bin/check-mysql-innodb-lock.rb - About 2 hrs to fix

          Method run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
          Severity: Minor
          Found in bin/check-mysql-msr-replication-status.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method replication_check has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
          Open

            def replication_check(db_user, db_pass, db_socket)
    table = {}
    begin
      cmd = "#{config[:binary]} -u #{db_user} -h #{config[:hostname]} --port #{config[:port]} \
        --socket #{db_socket} -p\"#{db_pass.strip}\"  -e 'SHOW SLAVE STATUS\\G'"
          Severity: Minor
          Found in bin/check-mysql-status.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
          Open

            def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
          Severity: Minor
          Found in bin/check-mysql-connections.rb - About 2 hrs to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Method run has 62 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
          Severity: Major
          Found in bin/check-mysql-msr-replication-status.rb - About 2 hrs to fix

            Method run has 58 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
            Severity: Major
            Found in bin/check-mysql-replication-status.rb - About 2 hrs to fix

              Method run has 52 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                def run
    # props to https://github.com/coredump/hoardd/blob/master/scripts-available/mysql.coffee

    metrics = metrics_hash
              Severity: Major
              Found in bin/metrics-mysql-graphite.rb - About 2 hrs to fix

                Method run has 49 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                  def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
                Severity: Minor
                Found in bin/check-mysql-disk.rb - About 1 hr to fix

                  Method replication_check has 45 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                    def replication_check(db_user, db_pass, db_socket)
    table = {}
    begin
      cmd = "#{config[:binary]} -u #{db_user} -h #{config[:hostname]} --port #{config[:port]} \
        --socket #{db_socket} -p\"#{db_pass.strip}\"  -e 'SHOW SLAVE STATUS\\G'"
                  Severity: Minor
                  Found in bin/check-mysql-status.rb - About 1 hr to fix

                    Method fetcher has 40 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                      def fetcher(db_user, db_pass, db_socket)
    metrics = metrics_hash
    # FIXME: this needs refactoring
    if config[:check] == 'metric' # rubocop:disable Style/GuardClause
      mysql_shorthostname = config[:hostname].tr('.', '_')
                    Severity: Minor
                    Found in bin/metrics-mysql-raw.rb - About 1 hr to fix

                      Method run has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
                      Severity: Minor
                      Found in bin/check-mysql-select-count.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method configuration_metrics has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def configuration_metrics(metrics, db_user, db_pass, db_socket)
    mysql_shorthostname = config[:hostname].tr('.', '_')
    table = []
    cmd = "#{config[:binary]} -u #{db_user} -h #{config[:hostname]} \
--port #{config[:port]} --socket #{db_socket} -p\"#{db_pass.chomp}\" --batch \
                      Severity: Minor
                      Found in bin/metrics-mysql-raw.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
                      Severity: Minor
                      Found in bin/metrics-mysql-multiple-select-count.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method run has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
                      Open

                        def run
    if config[:ini]
      ini = IniFile.load(config[:ini])
      section = ini[config[:ini_section]]
      db_user = section['user']
                      Severity: Minor
                      Found in bin/check-mysql-threads.rb - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Severity
                      Category
                      Status
                      Source
                      Language