sensu-plugins/sensu-plugins-puppet

View on GitHub

Showing 7 of 16 total issues

Method run has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    unless File.exist?(config[:report_file])
      unknown "File #{config[:report_file]} not found"
    end

Severity: Minor
Found in bin/check-puppet-last-run-report.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    unless File.exist?(config[:summary_file])
      unknown "File #{config[:summary_file]} not found"
    end

Severity: Minor
Found in bin/check-puppet-last-run.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 69 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    unless File.exist?(config[:report_file])
      unknown "File #{config[:report_file]} not found"
    end

Severity: Major
Found in bin/check-puppet-last-run-report.rb - About 2 hrs to fix

    Method run has 59 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        unless File.exist?(config[:summary_file])
          unknown "File #{config[:summary_file]} not found"
        end
    
    
    Severity: Major
    Found in bin/check-puppet-last-run.rb - About 2 hrs to fix

      Method run has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def run
          unless File.exist?(config[:summary_file])
            unknown "File #{config[:summary_file]} not found"
          end
      
      
      Severity: Minor
      Found in bin/check-puppet-errors.rb - About 1 hr to fix

        Method run has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
        Open

          def run
            unless File.exist?(config[:summary_file])
              unknown "File #{config[:summary_file]} not found"
            end
        
        
        Severity: Minor
        Found in bin/check-puppet-errors.rb - About 1 hr to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method report_value has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

          def report_value(list, name)
            value = 0
            if list
              list['values'].each do |v|
                if v[0] == name
        Severity: Minor
        Found in bin/check-puppet-last-run-report.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language