sensu-plugins/sensu-plugins-zookeeper

View on GitHub

Showing 9 of 9 total issues

Method run has a Cognitive Complexity of 38 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    timestamp = Time.now.to_i

    json = exhibitor_status

Severity: Minor
Found in bin/metrics-zookeeper-cluster.rb - About 5 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
Open

  def run
    timestamp = Time.now.to_i
    response  = zk_command(:mntr)
    metrics   = {}

Severity: Minor
Found in bin/metrics-zookeeper.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method run has 70 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def run
    timestamp = Time.now.to_i

    json = exhibitor_status

Severity: Major
Found in bin/metrics-zookeeper-cluster.rb - About 2 hrs to fix

    Method run has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def run
        timestamp = Time.now.to_i
        response  = zk_command(:mntr)
        metrics   = {}
    
    
    Severity: Major
    Found in bin/metrics-zookeeper.rb - About 2 hrs to fix

      Method follow_url has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
      Open

        def follow_url(uri_str,
                       agent = "sensu-plugins-zookeeper/#{SensuPluginsZookeeper::Version::VER_STRING}",
                       max_attempts = 10,
                       timeout = 10)
          attempts = 0
      Severity: Minor
      Found in bin/metrics-zookeeper-cluster.rb - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method follow_url has 37 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        def follow_url(uri_str,
                       agent = "sensu-plugins-zookeeper/#{SensuPluginsZookeeper::Version::VER_STRING}",
                       max_attempts = 10,
                       timeout = 10)
          attempts = 0
      Severity: Minor
      Found in bin/metrics-zookeeper-cluster.rb - About 1 hr to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def zk_command(four_letter_word)
            TCPSocket.open(config[:server], config[:port]) do |socket|
              socket.write four_letter_word.to_s
              ready = IO.select([socket], nil, nil, config[:timeout])
        
        
        Severity: Major
        Found in bin/metrics-zookeeper.rb and 1 other location - About 1 hr to fix
        bin/check-zookeeper-mode.rb on lines 55..65

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

          def zk_command(four_letter_word)
            TCPSocket.open(config[:server], config[:port]) do |socket|
              socket.write four_letter_word.to_s
              ready = IO.select([socket], nil, nil, config[:timeout])
        
        
        Severity: Major
        Found in bin/check-zookeeper-mode.rb and 1 other location - About 1 hr to fix
        bin/metrics-zookeeper.rb on lines 57..66

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Method znode_status has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          def znode_status
            zk = Zookeeper.new(config[:server])
            znode = zk.get(path: config[:znode])
        
            if znode[:stat].exists?
        Severity: Minor
        Found in bin/check-znode.rb - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Severity
        Category
        Status
        Source
        Language