Sign upLogin

sensu/sensu-spawn

View on GitHub
Star

Showing 3 of 3 total issues

Method child_process has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
Open

      def child_process(command, options={})
        child, reader, writer = build_child_process(command)
        child.duplex = true if options[:data]
        @@mutex.synchronize do
          child.start
Severity: Minor
Found in lib/sensu/spawn.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method write_and_read has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
Open

      def write_and_read(writer, reader, data)
        buffer = (data || "").dup
        output = ""
        loop do
          unless buffer.empty?
Severity: Minor
Found in lib/sensu/spawn.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method child_process has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

      def child_process(command, options={})
        child, reader, writer = build_child_process(command)
        child.duplex = true if options[:data]
        @@mutex.synchronize do
          child.start
Severity: Minor
Found in lib/sensu/spawn.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language