Sign upLogin

sequelize/sequelize

View on GitHub
Star
src/dialects/sqlite/query.js

Summary

Maintainability
F
4 days
Test Coverage

Function _handleQueryResponse has a Cognitive Complexity of 47 (exceeds 5 allowed). Consider refactoring.
Open

  _handleQueryResponse(metaData, columnTypes, err, results) {
    if (err) {
      err.sql = this.sql;
      throw this.formatError(err);
    }
Severity: Minor
Found in src/dialects/sqlite/query.js - About 7 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

File query.js has 399 lines of code (exceeds 250 allowed). Consider refactoring.
Open

const _ = require('lodash');
const Utils = require('../../utils');
const AbstractQuery = require('../abstract/query');
const QueryTypes = require('../../query-types');
const sequelizeErrors = require('../../errors');
Severity: Minor
Found in src/dialects/sqlite/query.js - About 5 hrs to fix

    Function _handleQueryResponse has 129 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      _handleQueryResponse(metaData, columnTypes, err, results) {
    if (err) {
      err.sql = this.sql;
      throw this.formatError(err);
    }
    Severity: Major
    Found in src/dialects/sqlite/query.js - About 5 hrs to fix

      Function run has 70 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        async run(sql, parameters) {
    const conn = this.connection;
    this.sql = sql;
    const method = this.getDatabaseMethod();
    let complete;
      Severity: Major
      Found in src/dialects/sqlite/query.js - About 2 hrs to fix

        Function formatError has 51 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

          formatError(err) {
    switch (err.code) {
      case 'SQLITE_CONSTRAINT': {
        if (err.message.includes('FOREIGN KEY constraint failed')) {
          return new sequelizeErrors.ForeignKeyConstraintError({
        Severity: Major
        Found in src/dialects/sqlite/query.js - About 2 hrs to fix

          Function formatError has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
          Open

            formatError(err) {
    switch (err.code) {
      case 'SQLITE_CONSTRAINT': {
        if (err.message.includes('FOREIGN KEY constraint failed')) {
          return new sequelizeErrors.ForeignKeyConstraintError({
          Severity: Minor
          Found in src/dialects/sqlite/query.js - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Function parseConstraintsFromSql has 38 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            parseConstraintsFromSql(sql) {
    let constraints = sql.split('CONSTRAINT ');
    let referenceTableName, referenceTableKeys, updateAction, deleteAction;
    constraints.splice(0, 1);
    constraints = constraints.map(constraintSql => {
          Severity: Minor
          Found in src/dialects/sqlite/query.js - About 1 hr to fix

            Function _collectModels has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
            Open

              _collectModels(include, prefix) {
    const ret = {};

    if (include) {
      for (const _include of include) {
            Severity: Minor
            Found in src/dialects/sqlite/query.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function formatBindParameters has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

              static formatBindParameters(sql, values, dialect) {
    let bindParam;
    if (Array.isArray(values)) {
      bindParam = {};
      values.forEach((v, i) => {
            Severity: Minor
            Found in src/dialects/sqlite/query.js - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                  return results;
            Severity: Major
            Found in src/dialects/sqlite/query.js - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                    return [results, metaData];
              Severity: Major
              Found in src/dialects/sqlite/query.js - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                      return [result, null];
                Severity: Major
                Found in src/dialects/sqlite/query.js - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                        return results;
                  Severity: Major
                  Found in src/dialects/sqlite/query.js - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                          return results;
                    Severity: Major
                    Found in src/dialects/sqlite/query.js - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                            return results;
                      Severity: Major
                      Found in src/dialects/sqlite/query.js - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                              return metaData.changes;
                        Severity: Major
                        Found in src/dialects/sqlite/query.js - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                return [result, metaData.changes];
                          Severity: Major
                          Found in src/dialects/sqlite/query.js - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                return result;
                            Severity: Major
                            Found in src/dialects/sqlite/query.js - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                    return this.handleShowIndexesQuery(results);
                              Severity: Major
                              Found in src/dialects/sqlite/query.js - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                      return result;
                                Severity: Major
                                Found in src/dialects/sqlite/query.js - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                        return results[0];
                                  Severity: Major
                                  Found in src/dialects/sqlite/query.js - About 30 mins to fix

                                    Avoid too many return statements within this function.
                                    Open

                                          return results[0].version;
                                    Severity: Major
                                    Found in src/dialects/sqlite/query.js - About 30 mins to fix

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                              if (
          metaData.constructor.name === 'Statement' &&
          this.model &&
          this.model.autoIncrementAttribute &&
          this.model.autoIncrementAttribute === this.model.primaryKeyAttribute &&
                                      Severity: Major
                                      Found in src/dialects/sqlite/query.js and 1 other location - About 2 hrs to fix
                                      src/dialects/mysql/query.js on lines 96..112

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 82.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      Similar blocks of code found in 2 locations. Consider refactoring.
                                      Open

                                                for (let i = startId; i < startId + metaData.changes; i++) {
            result.push({
              [this.model.rawAttributes[this.model.primaryKeyAttribute].field]: i
            });
          }
                                      Severity: Major
                                      Found in src/dialects/sqlite/query.js and 1 other location - About 1 hr to fix
                                      src/dialects/mysql/query.js on lines 105..109

                                      Duplicated Code

                                      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                      Tuning

                                      This issue has a mass of 72.

                                      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                      Refactorings

                                      Further Reading

                                      There are no issues that match your filters.

                                      Category
                                      Status