serianox/bishop

View on GitHub
lib/index.ts

Summary

Maintainability
C
1 day
Test Coverage

File index.ts has 257 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import * as child_process from "child_process";
import { ParsedPath } from "path";
import { BSError } from "./error";
import { debug, info, warn } from "./logging";
import { Declaration, parseConfiguration } from "./parser";
Severity: Minor
Found in lib/index.ts - About 2 hrs to fix

    Function runTask has 47 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                const runTask = (): void => {
                    const runNext = (currentTask: Task): void => {
                        jobs += currentTask.currentJobs;
    
                        run.complete(currentTask);
    Severity: Minor
    Found in lib/index.ts - About 1 hr to fix

      Avoid too many return statements within this function.
      Open

              return new Run(reachable, ready, waiting);
      Severity: Major
      Found in lib/index.ts - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return cycles;
        Severity: Major
        Found in lib/index.ts - About 30 mins to fix

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public setInProgress = () => {
                  warn(this._state !== State.NotStarted, "Setting `" + this.name + "` as state inProgress, but was in state `" + this.state + "`");
          
                  this._state = State.InProgress;
              }
          Severity: Major
          Found in lib/index.ts and 1 other location - About 1 hr to fix
          lib/index.ts on lines 150..154

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

              public setNotStarted = () => {
                  warn(this._state !== State.Unreachable, "Setting `" + this.name + "` as state notStarted, but was in state `" + this.state + "`");
          
                  this._state = State.NotStarted;
              }
          Severity: Major
          Found in lib/index.ts and 1 other location - About 1 hr to fix
          lib/index.ts on lines 157..161

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 73.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  debug("ready tasks: " + this._ready.map(_ => "`" + _.name + "`").join(", "));
          Severity: Minor
          Found in lib/index.ts and 1 other location - About 35 mins to fix
          lib/index.ts on lines 300..300

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 2 locations. Consider refactoring.
          Open

                  debug("waiting tasks: " + this._waiting.map(_ => "`" + _.name + "`").join(", "));
          Severity: Minor
          Found in lib/index.ts and 1 other location - About 35 mins to fix
          lib/index.ts on lines 301..301

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 46.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status