Sign upLogin

serradura/kind

View on GitHub
Star
lib/kind/validator.rb

Summary

Maintainability
B
4 hrs
Test Coverage

Method kind_is_not has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
Open

    def kind_is_not(expected, value)
      case expected
      when ::Class
        return if expected == Kind.of_class(value) || value < expected
Severity: Minor
Found in lib/kind/validator.rb - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method kind_of has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def kind_of(expected, value)
      if ::Array === expected
        return if expected.any? { |type| type === value }

        "must be a kind of #{expected.map { |type| type.name }.join(', ')}"
Severity: Minor
Found in lib/kind/validator.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method call_validation_for has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def call_validation_for(attribute, value)
      expected = options[:with] || options[:in]

      return validate_with_default_strategy(expected, value) if expected
Severity: Minor
Found in lib/kind/validator.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

      return instance_of(expected, value) if expected = options[:instance_of]
Severity: Major
Found in lib/kind/validator.rb - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

          return array_with(expected, value) if expected = options[:array_with]
    Severity: Major
    Found in lib/kind/validator.rb - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

            return array_of(expected, value) if expected = options[:array_of]
      Severity: Major
      Found in lib/kind/validator.rb - About 30 mins to fix

        There are no issues that match your filters.

        Category
        Status