sethvargo/chef-sugar

View on GitHub

Showing 8 of 8 total issues

Class Chef has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

class Chef
  module Sugar
    module Architecture
      extend self

Severity: Minor
Found in lib/chef/sugar/architecture.rb - About 2 hrs to fix

    Class Chef has 22 methods (exceeds 20 allowed). Consider refactoring.
    Open

    class Chef
      module Sugar
        module Cloud
          extend self
    
    
    Severity: Minor
    Found in lib/chef/sugar/cloud.rb - About 2 hrs to fix

      Method compile_time has 48 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

            def compile_time(&block)
              message = <<-EOH
      
      The Chef Sugar recipe DSL method `compile_time' has been renamed to
      `at_compile_time'! This is a breaking change that was released in a patch
      Severity: Minor
      Found in lib/chef/sugar/filters.rb - About 1 hr to fix

        Method which has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

              def which(cmd)
                if Pathname.new(cmd).absolute?
                  File.executable?(cmd) ? cmd : nil
                else
                  paths = ENV['PATH'].split(::File::PATH_SEPARATOR) + %w(/bin /usr/bin /sbin /usr/sbin)
        Severity: Minor
        Found in lib/chef/sugar/shell.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method method_missing has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

            def method_missing(m, *args, &block)
              old_method_missing(m, *args, &block)
            rescue NoMethodError
              # The Node Attribute's key is the method name
              key = m.to_s
        Severity: Minor
        Found in lib/chef/sugar/node.rb - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Method best_ip_for has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
        Open

              def best_ip_for(node, other)
                if other['cloud']
                  if node['cloud'] && other['cloud']['provider'] == node['cloud']['provider']
                    other['cloud']['local_ipv4']
                  else
        Severity: Minor
        Found in lib/chef/sugar/ip.rb - About 25 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if data[node.chef_environment]
                  Chef::Log.debug "Using #{node.chef_environment} as the key"
                  data[node.chef_environment]
                else
                  Chef::Log.debug "#{node.chef_environment} key does not exist, using `default`"
        Severity: Minor
        Found in lib/chef/sugar/data_bag.rb and 1 other location - About 25 mins to fix
        lib/chef/sugar/data_bag.rb on lines 86..91

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if data[node.chef_environment]
                  Chef::Log.debug "Using #{node.chef_environment} as the key"
                  data[node.chef_environment]
                else
                  Chef::Log.debug "#{node.chef_environment} key does not exist, using `default`"
        Severity: Minor
        Found in lib/chef/sugar/data_bag.rb and 1 other location - About 25 mins to fix
        lib/chef/sugar/data_bag.rb on lines 119..124

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 30.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Severity
        Category
        Status
        Source
        Language