Sign upLogin

sferik/mlb

View on GitHub
Star

Showing 2 of 2 total issues

Method results_to_team has a Cognitive Complexity of 30 (exceeds 5 allowed). Consider refactoring.
Open

    def self.results_to_team(results) # rubocop:disable AbcSize, CyclomaticComplexity, MethodLength, PerceivedComplexity
      results['result'].map do |result|
        league      = result['league']
        division    = result['division']
        manager     = result['current_manager']
Severity: Minor
Found in lib/mlb/team.rb - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method mql_query has 47 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def self.mql_query # rubocop:disable MethodLength
      query = <<-eos
        [{
          "name":          null,
          "league": {
Severity: Minor
Found in lib/mlb/team.rb - About 1 hr to fix
    Severity
    Category
    Status
    Source
    Language