sghill/grunt-jenkins

View on GitHub
tasks/jenkins.js

Summary

Maintainability
D
2 days
Test Coverage

Function exports has 164 lines of code (exceeds 25 allowed). Consider refactoring.
Open

module.exports = function(grunt) {

  grunt.config.requires('jenkins.serverAddress');
  var pipelineDirectory = grunt.config('jenkins.pipelineDirectory') || 'pipeline';
  var serverAddress = grunt.config('jenkins.serverAddress');
Severity: Major
Found in tasks/jenkins.js - About 6 hrs to fix

    Function compareToJobsOnDisk has 48 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function compareToJobsOnDisk(serverJobsAndConfigurations) {
        var deferred = q.defer();
        fileSystem.loadJobs().
          then(function(jobNames) {
            var serverJobNames = _.pluck(serverJobsAndConfigurations, 'name');
    Severity: Minor
    Found in tasks/jenkins.js - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        grunt.registerTask('jenkins-list-jobs', 'list all found Jenkins jobs', function() {
          var done = this.async();
          server.fetchJobs().
            then(function(jobs) {
              _.each(jobs, function(j) {
      Severity: Major
      Found in tasks/jenkins.js and 1 other location - About 4 hrs to fix
      tasks/jenkins.js on lines 172..183

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

        grunt.registerTask('jenkins-list-plugins', 'list all enabled Jenkins plugins', function() {
          var done = this.async();
          server.fetchEnabledPlugins().
            then(function(plugins) {
              _.each(plugins, function(p) {
      Severity: Major
      Found in tasks/jenkins.js and 1 other location - About 4 hrs to fix
      tasks/jenkins.js on lines 159..170

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 130.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status