sghill/grunt-jenkins

View on GitHub
tasks/jenkinsServer.js

Summary

Maintainability
D
2 days
Test Coverage

Function JenkinsServer has 224 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function JenkinsServer(serverUrl, defaultOptions, fileSystem, grunt, jobUrlResolutionStrategy) {

  function verboseLogRequest(options) {
    var method = options.method || 'GET';
    grunt.verbose.writeln([method, options.url].join(' '));
Severity: Major
Found in tasks/jenkinsServer.js - About 1 day to fix

    Function JenkinsServer has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

    function JenkinsServer(serverUrl, defaultOptions, fileSystem, grunt, jobUrlResolutionStrategy) {
    
      function verboseLogRequest(options) {
        var method = options.method || 'GET';
        grunt.verbose.writeln([method, options.url].join(' '));
    Severity: Minor
    Found in tasks/jenkinsServer.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function fetchJobConfigurations has 30 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      this.fetchJobConfigurations = function(jobs) {
        var deferred = q.defer();
        var promises = _.map(jobs, function(j) {
          var d = q.defer(),
            options = _.extend(defaultOptions, {
    Severity: Minor
    Found in tasks/jenkinsServer.js - About 1 hr to fix

      Function fetchJobs has 29 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        this.fetchJobs = function() {
          var deferred = q.defer(),
            options = _.extend(defaultOptions, {
              url: [serverUrl, 'api', 'json'].join('/')
            });
      Severity: Minor
      Found in tasks/jenkinsServer.js - About 1 hr to fix

        Function JenkinsServer has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

        function JenkinsServer(serverUrl, defaultOptions, fileSystem, grunt, jobUrlResolutionStrategy) {
        Severity: Minor
        Found in tasks/jenkinsServer.js - About 35 mins to fix

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              request(options, function(e, r, b) {
                verboseLogRequest(options);
                verboseLogResponse(r);
                if (hasError(e, r) || authenticationFailed(r)) {
                  return deferred.reject(e);
          Severity: Major
          Found in tasks/jenkinsServer.js and 1 other location - About 2 hrs to fix
          tasks/jenkinsServer.js on lines 189..196

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Identical blocks of code found in 2 locations. Consider refactoring.
          Open

              request(options, function(e, r, b) {
                verboseLogRequest(options);
                verboseLogResponse(r);
                if (hasError(e, r) || authenticationFailed(r)) {
                  return deferred.reject(e);
          Severity: Major
          Found in tasks/jenkinsServer.js and 1 other location - About 2 hrs to fix
          tasks/jenkinsServer.js on lines 209..216

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 80.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          There are no issues that match your filters.

          Category
          Status