shimabox/screru

View on GitHub

Showing 32 of 32 total issues

Method takeFull has 73 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function takeFull(RemoteWebDriver $driver, $filepath, $filename, $sleep=1)
    {
        (int)$sleep <= 0 ?: sleep((int)$sleep);

        $_filename = $this->removeExtension($filename);
Severity: Major
Found in src/Screenshot/Screenshot.php - About 2 hrs to fix

    Function takeFull has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
    Open

        public function takeFull(RemoteWebDriver $driver, $filepath, $filename, $sleep=1)
        {
            (int)$sleep <= 0 ?: sleep((int)$sleep);
    
            $_filename = $this->removeExtension($filename);
    Severity: Minor
    Found in src/Screenshot/Screenshot.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function __construct has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
    Open

        public function __construct($browser)
        {
            switch ($browser) {
                case WebDriverBrowserType::FIREFOX: // firefox
                    if (getenv('ENABLED_FIREFOX_DRIVER') !== 'true') {
    Severity: Minor
    Found in src/Factory/DesiredCapabilities.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Observer has 21 functions (exceeds 20 allowed). Consider refactoring.
    Open

    class Observer implements Observable
    {
        /**
         * はじめて画面が描画されたときに行う処理
         * @var \Closure
    Severity: Minor
    Found in src/View/Observer.php - About 2 hrs to fix

      Method __construct has 54 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          public function __construct($browser)
          {
              switch ($browser) {
                  case WebDriverBrowserType::FIREFOX: // firefox
                      if (getenv('ENABLED_FIREFOX_DRIVER') !== 'true') {
      Severity: Major
      Found in src/Factory/DesiredCapabilities.php - About 2 hrs to fix

        Method takeElement has 45 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public function takeElement(RemoteWebDriver $driver, $filepath, $filename, SpecPool $specPool, $sleep=1)
            {
                // 一旦全画面のキャプチャを撮る
                $_filename = $this->removeExtension($filename);
                $tmpFullScreenshot = $this->takeFull($driver, $filepath, $_filename . '_tmp_' . microtime(true) . '.png', $sleep);
        Severity: Minor
        Found in src/Screenshot/Screenshot.php - About 1 hr to fix

          Method toPatchTheImage has 9 arguments (exceeds 4 allowed). Consider refactoring.
          Open

              private function toPatchTheImage($captureFile, $dest, $src, $destX, $destY, $srcX, $srcY, $srcW, $srcH)
          Severity: Major
          Found in src/Screenshot/Screenshot.php - About 1 hr to fix

            Method notify has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                private function notify(
                    RemoteWebDriver $driver, 
                    $contentsWidth, 
                    $contentsHeight, 
                    $scrollWidth, 
            Severity: Minor
            Found in src/Screenshot/Screenshot.php - About 1 hr to fix

              Method notify has 8 arguments (exceeds 4 allowed). Consider refactoring.
              Open

                      RemoteWebDriver $driver, 
                      $contentsWidth, 
                      $contentsHeight, 
                      $scrollWidth, 
                      $scrollHeight, 
              Severity: Major
              Found in src/Screenshot/Screenshot.php - About 1 hr to fix

                Function notify has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
                Open

                    private function notify(
                        RemoteWebDriver $driver, 
                        $contentsWidth, 
                        $contentsHeight, 
                        $scrollWidth, 
                Severity: Minor
                Found in src/Screenshot/Screenshot.php - About 55 mins to fix

                Cognitive Complexity

                Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                A method's cognitive complexity is based on a few simple rules:

                • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                • Code is considered more complex for each "break in the linear flow of the code"
                • Code is considered more complex when "flow breaking structures are nested"

                Further reading

                Method notifyThatViewWidthHasReachedEndForFirst has 5 arguments (exceeds 4 allowed). Consider refactoring.
                Open

                        RemoteWebDriver $driver,
                        $contentsWidth,
                        $contentsHeight,
                        $scrolledWidth,
                        $scrolledHeight
                Severity: Minor
                Found in src/View/Observable.php - About 35 mins to fix

                  Method notifyThatViewWidthHasReachedEndForFirst has 5 arguments (exceeds 4 allowed). Consider refactoring.
                  Open

                          RemoteWebDriver $driver,
                          $contentsWidth,
                          $contentsHeight,
                          $scrolledWidth,
                          $scrolledHeight
                  Severity: Minor
                  Found in src/View/Observer.php - About 35 mins to fix

                    Method notifyLastRender has 5 arguments (exceeds 4 allowed). Consider refactoring.
                    Open

                            RemoteWebDriver $driver,
                            $contentsWidth,
                            $contentsHeight,
                            $scrolledWidth,
                            $scrolledHeight
                    Severity: Minor
                    Found in src/View/Observable.php - About 35 mins to fix

                      Method notifyScreenScroll has 5 arguments (exceeds 4 allowed). Consider refactoring.
                      Open

                              RemoteWebDriver $driver,
                              $contentsWidth,
                              $contentsHeight,
                              $scrolledWidth,
                              $scrolledHeight
                      Severity: Minor
                      Found in src/View/Observable.php - About 35 mins to fix

                        Method notifyThatViewHeightHasReachedEndForFirst has 5 arguments (exceeds 4 allowed). Consider refactoring.
                        Open

                                RemoteWebDriver $driver,
                                $contentsWidth,
                                $contentsHeight,
                                $scrolledWidth,
                                $scrolledHeight
                        Severity: Minor
                        Found in src/View/Observable.php - About 35 mins to fix

                          Method notifyFirstRender has 5 arguments (exceeds 4 allowed). Consider refactoring.
                          Open

                                  RemoteWebDriver $driver,
                                  $contentsWidth,
                                  $contentsHeight,
                                  $scrolledWidth,
                                  $scrolledHeight
                          Severity: Minor
                          Found in src/View/Observer.php - About 35 mins to fix

                            Method notifyFirstVerticalScroll has 5 arguments (exceeds 4 allowed). Consider refactoring.
                            Open

                                    RemoteWebDriver $driver,
                                    $contentsWidth,
                                    $contentsHeight,
                                    $scrolledWidth,
                                    $scrolledHeight
                            Severity: Minor
                            Found in src/View/Observer.php - About 35 mins to fix

                              Method notifyLastRender has 5 arguments (exceeds 4 allowed). Consider refactoring.
                              Open

                                      RemoteWebDriver $driver,
                                      $contentsWidth,
                                      $contentsHeight,
                                      $scrolledWidth,
                                      $scrolledHeight
                              Severity: Minor
                              Found in src/View/Observer.php - About 35 mins to fix

                                Method notifyScreenScroll has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                Open

                                        RemoteWebDriver $driver,
                                        $contentsWidth,
                                        $contentsHeight,
                                        $scrolledWidth,
                                        $scrolledHeight
                                Severity: Minor
                                Found in src/View/Observer.php - About 35 mins to fix

                                  Method notifyThatViewHeightHasReachedEndForFirst has 5 arguments (exceeds 4 allowed). Consider refactoring.
                                  Open

                                          RemoteWebDriver $driver,
                                          $contentsWidth,
                                          $contentsHeight,
                                          $scrolledWidth,
                                          $scrolledHeight
                                  Severity: Minor
                                  Found in src/View/Observer.php - About 35 mins to fix
                                    Severity
                                    Category
                                    Status
                                    Source
                                    Language