Sign upLogin

shioyama/mobility

View on GitHub
Star
lib/mobility/plugins/active_model/dirty.rb

Summary

Maintainability
A
45 mins
Test Coverage

File dirty.rb has 266 lines of code (exceeds 250 allowed). Consider refactoring.
Wontfix

module Mobility
  module Plugins
    module ActiveModel
=begin
Severity: Minor
Found in lib/mobility/plugins/active_model/dirty.rb - About 2 hrs to fix

    Method define_dirty_methods has a Cognitive Complexity of 11 (exceeds 8 allowed). Consider refactoring.
    Open

            def define_dirty_methods(attribute_names)
          attribute_names.each do |name|
            dirty_handler_methods.each_pattern(name) do |method_name, attribute_method|
              define_method(method_name) do |*args|
                # for %s_changed?(from:, to:) pattern
    Severity: Minor
    Found in lib/mobility/plugins/active_model/dirty.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Use == if you meant to do a comparison or wrap the expression in parentheses to indicate you meant to assign in a condition.
    Wontfix

                  if change = attribute_change(attr_name)
    Severity: Minor
    Found in lib/mobility/plugins/active_model/dirty.rb by rubocop

    This cop checks for assignments in the conditions of if/while/until.

    Example:

    # bad

if some_var = true
  do_something
end

    Example:

    # good

if some_var == true
  do_something
end

    There are no issues that match your filters.

    Category
    Status