shootismoke/common

View on GitHub

Showing 8 of 19 total issues

Function renderCigarette has 68 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function renderCigarette(
    orientation: 'horizontal' | 'vertical',
    percentage: number,
    fullCigaretteLength: number,
    additionalStyle?: StyleProp<ViewStyle>
Severity: Major
Found in packages/ui/src/components/Cigarettes/Cigarette/Cigarette.tsx - About 2 hrs to fix

    Function fetchAlgolia has 65 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    export function fetchAlgolia(
        search: string,
        gps?: LatLng
    ): TE.TaskEither<Error, AlgoliaHit[]> {
        return retry(
    Severity: Major
    Found in packages/ui/src/util/fetchAlgolia.ts - About 2 hrs to fix

      Function Cigarettes has 57 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      export function Cigarettes(props: CigarettesProps): React.ReactElement {
          const {
              cigarettes: realCigarettes,
              cigaretteStyle,
              fullCigaretteLength = 90,
      Severity: Major
      Found in packages/ui/src/components/Cigarettes/Cigarettes.tsx - About 2 hrs to fix

        Function testTE has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        export function testTE<T>(
            te: TE.TaskEither<Error, T>,
            normalize: (data: T) => E.Either<Error, OpenAQResults>,
            done: jest.DoneCallback
        ): void {
        Severity: Minor
        Found in packages/dataproviders/test/util/testUtil.ts - About 1 hr to fix

          Function Cigarettes has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

          export function Cigarettes(props: CigarettesProps): React.ReactElement {
              const {
                  cigarettes: realCigarettes,
                  cigaretteStyle,
                  fullCigaretteLength = 90,
          Severity: Minor
          Found in packages/ui/src/components/Cigarettes/Cigarettes.tsx - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Consider simplifying this complex logical expression.
          Open

              if (
                  from === 'ppb' ||
                  from === 'ppm' ||
                  from === 'particles/cm³' ||
                  to === 'ppb' ||
          Severity: Major
          Found in packages/convert/src/convert.ts - About 40 mins to fix

            Function normalize has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
            Open

            export function normalize(data: AqicnStaton): E.Either<Error, OpenAQResults> {
                if (!data || typeof data === 'string') {
                    return E.left(
                        providerError('aqicn', `Cannot normalized ${data || 'undefined'}`)
                    );
            Severity: Minor
            Found in packages/dataproviders/src/providers/aqicn/normalize.ts - About 35 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Avoid too many return statements within this function.
            Open

                return pipe(
                    getCountryCode(countryRaw),
                    E.fromOption(() =>
                        providerError('aqicn', `Cannot get code from country ${countryRaw}`)
                    ),
            Severity: Major
            Found in packages/dataproviders/src/providers/aqicn/normalize.ts - About 30 mins to fix
              Severity
              Category
              Status
              Source
              Language