Sign upLogin

simplay/bofrev

View on GitHub
Star
demos/tetris/collision_checker.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method initialize has 29 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def initialize(shape, operation, shift = Point2f.new(0,0))
    @state = :moveable

    if operation == :rotate
      next_rot_hit_points = shape.next_rotated_shape
Severity: Minor
Found in demos/tetris/collision_checker.rb - About 1 hr to fix

    Method initialize has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def initialize(shape, operation, shift = Point2f.new(0,0))
    @state = :moveable

    if operation == :rotate
      next_rot_hit_points = shape.next_rotated_shape
    Severity: Minor
    Found in demos/tetris/collision_checker.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status