Sign upLogin

sinisterchipmunk/bitcoin-client

View on GitHub
Star

Showing 6 of 6 total issues

Class Client has 63 methods (exceeds 20 allowed). Consider refactoring.
Open

class BitcoinClient::Client
  attr_reader :api
  def user; api.user; end
  def pass; api.pass; end
  def host; api.host; end
Severity: Major
Found in lib/bitcoin-client/client.rb - About 1 day to fix

    Method sendfrom has 6 arguments (exceeds 4 allowed). Consider refactoring.
    Open

      def sendfrom(fromaccount, tobitcoinaddress, amount, minconf = 1, comment = nil, comment_to = nil)
    Severity: Minor
    Found in lib/bitcoin-client/dsl.rb - About 45 mins to fix

      Method sendfrom has 6 arguments (exceeds 4 allowed). Consider refactoring.
      Open

        def sendfrom(fromaccount, tobitcoinaddress, amount, minconf = 1, comment = nil, comment_to = nil)
      Severity: Minor
      Found in lib/bitcoin-client/client.rb - About 45 mins to fix

        Method move has 5 arguments (exceeds 4 allowed). Consider refactoring.
        Open

          def move(fromaccount, toaccount, amount, minconf = 1, comment = nil)
        Severity: Minor
        Found in lib/bitcoin-client/client.rb - About 35 mins to fix

          Method move has 5 arguments (exceeds 4 allowed). Consider refactoring.
          Open

            def move(fromaccount, toaccount, amount, minconf = 1, comment = nil)
          Severity: Minor
          Found in lib/bitcoin-client/dsl.rb - About 35 mins to fix

            Method symbolize_keys has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
            Open

              def symbolize_keys(hash)
    case hash
    when Hash
      hash.inject({}) do |result, (key, value)|
        key = key.to_sym if key.kind_of?(String)
            Severity: Minor
            Found in lib/bitcoin-client/rpc.rb - About 25 mins to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Severity
            Category
            Status
            Source
            Language