slack-ruby/slack-ruby-bot-server

View on GitHub

Showing 6 of 11 total issues

Method sort_order has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

        def sort_order(options = {})
          params[:sort] = options[:default_sort_order] unless params[:sort]
          return [] unless params[:sort]

          sort_order = params[:sort].to_s
Severity: Minor
Found in lib/slack-ruby-bot-server/api/helpers/sort_helpers.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method paginate_by_cursor has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
Open

          def paginate_by_cursor(coll, options)
            raise 'Both cursor and offset parameters are present, these are mutually exclusive.' if params.key?(:offset) && params.key?(:cursor)

            results = { results: [], next: nil }
            size = (params[:size] || 10).to_i
Severity: Minor
Found in lib/slack-ruby-bot-server/api/helpers/cursor_helpers.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method paginate_by_cursor has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

          def paginate_by_cursor(coll, _options)
            raise 'Both cursor and offset parameters are present, these are mutually exclusive.' if params.key?(:offset) && params.key?(:cursor)

            results = { results: [], next: nil }
            coll = coll.skip(params[:offset].to_i) if params.key?(:offset)
Severity: Minor
Found in lib/slack-ruby-bot-server/api/helpers/cursor_helpers.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method ping_if_active! has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
Open

    def ping_if_active!
      return unless active?

      ping!
    rescue Slack::Web::Api::Errors::SlackError => e
Severity: Minor
Found in lib/slack-ruby-bot-server/models/team/methods.rb - About 55 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method sort has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

        def sort(coll, options = {})
          sort_order = sort_order(options)
          unless sort_order.empty?
            if coll.respond_to?(:order)
              sort_order.each do |s|
Severity: Minor
Found in lib/slack-ruby-bot-server/api/helpers/sort_helpers.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method _every has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def _every(tt, options = {}, &_block)
      ::Async::Reactor.run do |task|
        loop do
          begin
            if options[:run_on_start]
Severity: Minor
Found in lib/slack-ruby-bot-server/service.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Severity
Category
Status
Source
Language