socketry/falcon

View on GitHub

Showing 11 of 11 total issues

Method call has 46 lines of code (exceeds 25 allowed). Consider refactoring.
Open

            def call(request)
                request_path, query_string = request.path.split('?', 2)
                server_name, server_port = (request.authority || '').split(':', 2)
                
                env = {
Severity: Minor
Found in lib/falcon/adapters/rack.rb - About 1 hr to fix

    Method read has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

                def read(length = nil, buffer = nil)
                    buffer ||= Async::IO::Buffer.new
                    buffer.clear
                    
                    until buffer.bytesize == length
    Severity: Minor
    Found in lib/falcon/adapters/input.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

                def call(request)
                    request_path, query_string = request.path.split('?', 2)
                    server_name, server_port = (request.authority || '').split(':', 2)
                    
                    env = {
    Severity: Minor
    Found in lib/falcon/adapters/rack.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method unwrap_request has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

                def unwrap_request(request, env)
                    if content_type = request.headers.delete('content-type')
                        env[CONTENT_TYPE] = content_type
                    end
                    
    Severity: Minor
    Found in lib/falcon/adapters/rack.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                def call
                    Async.logger.info(self) do |buffer|
                        buffer.puts "Falcon Proxy v#{VERSION} taking flight!"
                        buffer.puts "- Binding to: #{@options[:bind]}"
                        buffer.puts "- To terminate: Ctrl-C or kill #{Process.pid}"
    Severity: Minor
    Found in lib/falcon/command/proxy.rb and 1 other location - About 40 mins to fix
    lib/falcon/command/redirect.rb on lines 54..62

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

                def call
                    Async.logger.info(self) do |buffer|
                        buffer.puts "Falcon Redirect v#{VERSION} taking flight!"
                        buffer.puts "- Binding to: #{@options[:bind]}"
                        buffer.puts "- To terminate: Ctrl-C or kill #{Process.pid}"
    Severity: Minor
    Found in lib/falcon/command/redirect.rb and 1 other location - About 40 mins to fix
    lib/falcon/command/proxy.rb on lines 53..61

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 37.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method wrap has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

                def self.wrap(status, headers, body)
                    # In no circumstance do we want this header propagating out:
                    if length = headers.delete(CONTENT_LENGTH)
                        # We don't really trust the user to provide the right length to the transport.
                        length = Integer(length)
    Severity: Minor
    Found in lib/falcon/adapters/output.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method build_ssl_context has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

            def build_ssl_context(hostname = self.hostname)
                authority = Localhost::Authority.fetch(hostname)
                
                authority.server_context.tap do |context|
                    context.alpn_select_cb = lambda do |protocols|
    Severity: Minor
    Found in lib/falcon/endpoint.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                    context.alpn_select_cb = lambda do |protocols|
                        if protocols.include? "h2"
                            return "h2"
                        elsif protocols.include? "http/1.1"
                            return "http/1.1"
    Severity: Minor
    Found in lib/falcon/endpoint.rb and 2 other locations - About 15 mins to fix
    lib/falcon/configuration/self_signed_tls.rb on lines 32..41
    lib/falcon/configuration/tls.rb on lines 47..56

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                context.alpn_select_cb = lambda do |protocols|
                    if protocols.include? "h2"
                        return "h2"
                    elsif protocols.include? "http/1.1"
                        return "http/1.1"
    Severity: Minor
    Found in lib/falcon/configuration/self_signed_tls.rb and 2 other locations - About 15 mins to fix
    lib/falcon/configuration/tls.rb on lines 47..56
    lib/falcon/endpoint.rb on lines 36..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Identical blocks of code found in 3 locations. Consider refactoring.
    Open

                context.alpn_select_cb = lambda do |protocols|
                    if protocols.include? "h2"
                        return "h2"
                    elsif protocols.include? "http/1.1"
                        return "http/1.1"
    Severity: Minor
    Found in lib/falcon/configuration/tls.rb and 2 other locations - About 15 mins to fix
    lib/falcon/configuration/self_signed_tls.rb on lines 32..41
    lib/falcon/endpoint.rb on lines 36..45

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 25.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language