socketry/nio4r

View on GitHub
lib/nio/selector.rb

Summary

Maintainability
B
5 hrs
Test Coverage

Method select has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

    def select(timeout = nil)
      selected_monitors = Set.new

      @lock.synchronize do
        readers = [@wakeup]
Severity: Minor
Found in lib/nio/selector.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method select has 32 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def select(timeout = nil)
      selected_monitors = Set.new

      @lock.synchronize do
        readers = [@wakeup]
Severity: Minor
Found in lib/nio/selector.rb - About 1 hr to fix

    Method register has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def register(io, interest)
          unless defined?(::OpenSSL) && io.is_a?(::OpenSSL::SSL::SSLSocket)
            io = IO.try_convert(io)
          end
    
    
    Severity: Minor
    Found in lib/nio/selector.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method close has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def close
          @lock.synchronize do
            return if @closed
    
            begin
    Severity: Minor
    Found in lib/nio/selector.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status