socketry/rubydns

View on GitHub

Showing 6 of 6 total issues

Method startup has 42 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def startup
        cache = {}
        stats = { requested: 0 }

        # Start the RubyDNS server
Severity: Minor
Found in examples/fortune-dns.rb - About 1 hr to fix

    Method call has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

                def call(server, name, resource_class, transaction)
                    unless match(name, resource_class)
                        server.logger.debug "<#{transaction.query.id}> Resource class #{resource_class} failed to match #{@pattern[1].inspect}!"
                        
                        return false
    Severity: Minor
    Found in lib/rubydns/rule_based_server.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method call has 27 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

                def call(server, name, resource_class, transaction)
                    unless match(name, resource_class)
                        server.logger.debug "<#{transaction.query.id}> Resource class #{resource_class} failed to match #{@pattern[1].inspect}!"
                        
                        return false
    Severity: Minor
    Found in lib/rubydns/rule_based_server.rb - About 1 hr to fix

      Method startup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def startup
              cache = {}
              stats = { requested: 0 }
      
              # Start the RubyDNS server
      Severity: Minor
      Found in examples/fortune-dns.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method startup has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          def startup
              RubyDNS.run_server(INTERFACES) do
                  fallback_resolver_supervisor = RubyDNS::Resolver.supervise(RubyDNS::System.nameservers)
                  
                  match(//, IN::A) do |transaction|
      Severity: Minor
      Found in examples/geoip-dns.rb - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

                      return false
      Severity: Major
      Found in lib/rubydns/rule_based_server.rb - About 30 mins to fix
        Severity
        Category
        Status
        Source
        Language