Showing 10 of 10 total issues
Method for
has a Cognitive Complexity of 29 (exceeds 5 allowed). Consider refactoring. Open
def self.for(owner, client, attributes = {})
return nil unless owner and client
unless client.is_a?(Client)
raise ArgumentError, "The argument should be a #{Client}, instead it was a #{client.class}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate!
has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring. Open
def validate!
if @transport_error
@error = @transport_error.error
@error_description = @transport_error.error_description
return
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method redirect_uri
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
def redirect_uri
return nil unless @client
redirect_uris = @client.redirect_uri.split(';')
base_redirect_uri = if redirect_uris.count > 1
@params[REDIRECT_URI]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate!
has 36 lines of code (exceeds 25 allowed). Consider refactoring. Open
def validate!
if @transport_error
@error = @transport_error.error
@error_description = @transport_error.error_description
return
Method validate_assertion
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
def validate_assertion
REQUIRED_ASSERTION_PARAMS.each do |param|
next if @params.has_key?(param)
@error = INVALID_REQUEST
@error_description = "Missing required parameter #{param}"
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method for
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
def self.for(owner, client, attributes = {})
return nil unless owner and client
unless client.is_a?(Client)
raise ArgumentError, "The argument should be a #{Client}, instead it was a #{client.class}"
Method validate!
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
def validate!
return @error = '' unless @access_token
return @error = INVALID_TOKEN unless @authorization
return @error = EXPIRED_TOKEN if @authorization.expired?
return @error = INSUFFICIENT_SCOPE unless @authorization.in_scope?(@scopes)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method parse
has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring. Open
def parse(resource_owner, env)
error = detect_transport_error(env)
request = request_from(env)
params = request.params
auth = auth_params(env)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method initialize
has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring. Open
def initialize(resource_owner, params, transport_error = nil)
@owner = resource_owner
@params = params
@scope = params[SCOPE]
@state = params[STATE]
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method validate_authorization_code
has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring. Open
def validate_authorization_code
unless @params[CODE]
@error = INVALID_REQUEST
@error_description = "Missing required parameter code"
end
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"