Sign upLogin

soumya92/barista

View on GitHub
Star
base/watchers/file/file.go

Summary

Maintainability
C
1 day
Test Coverage
A
91%

Method Watcher.tryWatch has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring.
Open

func (w *Watcher) tryWatch(restarted bool) error {
    currentLvl := -1
    for lvl, p := range w.hierarchy {
        err := w.fswatcher.Add(p)
        if err == nil {
Severity: Minor
Found in base/watchers/file/file.go - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method Watcher.tryWatch has 72 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func (w *Watcher) tryWatch(restarted bool) error {
    currentLvl := -1
    for lvl, p := range w.hierarchy {
        err := w.fswatcher.Add(p)
        if err == nil {
Severity: Minor
Found in base/watchers/file/file.go - About 1 hr to fix

    Avoid deeply nested control flow statements.
    Open

                        if !os.IsNotExist(err) {
                        l.Log("%s: %v", l.ID(w), err)
                        return err
                    }
    Severity: Major
    Found in base/watchers/file/file.go - About 45 mins to fix

      Method Watcher.tryWatch has 7 return statements (exceeds 4 allowed).
      Open

      func (w *Watcher) tryWatch(restarted bool) error {
    currentLvl := -1
    for lvl, p := range w.hierarchy {
        err := w.fswatcher.Add(p)
        if err == nil {
      Severity: Major
      Found in base/watchers/file/file.go - About 45 mins to fix

        TODO found
        Open

                        // TODO: Handle parent being moved. For most modules, this is not
        Severity: Minor
        Found in base/watchers/file/file.go by fixme

        There are no issues that match your filters.

        Category
        Status