soumya92/barista

View on GitHub
logging/id.go

Summary

Maintainability
A
40 mins
Test Coverage
A
97%

Function typeName has 6 return statements (exceeds 4 allowed).
Open

func typeName(typ reflect.Type) string {
    if typ == nil {
        return "nil"
    }
    name := typ.Name()
Severity: Major
Found in logging/id.go - About 40 mins to fix

    Your code does not pass gofmt in 3 places. Go fmt your code!
    Open

    // Copyright 2018 Google Inc.
    Severity: Minor
    Found in logging/id.go by gofmt

    func nameAndId should be nameAndID
    Open

    func nameAndId(thing interface{}) (name string, id ident) {
    Severity: Minor
    Found in logging/id.go by golint

    var parentId should be parentID
    Open

        if parentId := nodes[childId].parent; !parentId.zero() {
    Severity: Minor
    Found in logging/id.go by golint

    var parentId should be parentID
    Open

        parentName, parentId := nameAndId(parent)
    Severity: Minor
    Found in logging/id.go by golint

    var childId should be childID
    Open

        childName, childId := nameAndId(child)
    Severity: Minor
    Found in logging/id.go by golint

    var childId should be childID
    Open

            oldName, childId := nameAndId(child)
    Severity: Minor
    Found in logging/id.go by golint

    var rootId should be rootID
    Open

    var rootId = identify(Root)
    Severity: Minor
    Found in logging/id.go by golint

    var thingId should be thingID
    Open

        thingName, thingId := nameAndId(thing)
    Severity: Minor
    Found in logging/id.go by golint

    There are no issues that match your filters.

    Category
    Status