Sign upLogin

soup-bowl/Chromeboard

View on GitHub
Star

Showing 9 of 9 total issues

Function updatePageWithCurrentPrefs has a Cognitive Complexity of 20 (exceeds 5 allowed). Consider refactoring.
Open

function updatePageWithCurrentPrefs() {
    var prefs = storage.get('chromeboardPrefs', function (obj) {
        var opt = obj.chromeboardPrefs.urlCol;
            
        if (opt != "") {
Severity: Minor
Found in js/settings.js - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function rotation has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

function rotation(newtab = false) {
    originalTab = ROTATION_CURRENT; // Current identifier, for refreshing later.
    nextActive = ROTATION_CURRENT + 1; // The new tab that's being shown.
    if (nextActive > (ROTATION_TOTAL - 1)) {
        nextActive = 0;
Severity: Minor
Found in js/rotation.js - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function updatePageWithCurrentPrefs has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function updatePageWithCurrentPrefs() {
    var prefs = storage.get('chromeboardPrefs', function (obj) {
        var opt = obj.chromeboardPrefs.urlCol;
            
        if (opt != "") {
Severity: Minor
Found in js/settings.js - About 1 hr to fix

    Function prefs has 28 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        var prefs = storage.get('chromeboardPrefs', function (obj) {
        var opt = obj.chromeboardPrefs.urlCol;
            
        if (opt != "") {
            if(typeof opt === 'object') {
    Severity: Minor
    Found in js/settings.js - About 1 hr to fix

      Function saveSettings has 26 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

      function saveSettings(save = true) {
    if (save) {
        var siteEntry = $( "#sortable" ).find(".siteURLInput");
        var siteCollection = [];
        var dockPosDropdown = document.getElementById("dockplacement");
      Severity: Minor
      Found in js/settings.js - About 1 hr to fix

        Function toggleLockstate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
        Open

        function toggleLockstate(event) {
    event.preventDefault();
    if( $('#sb-unlocked').hasClass('hidden') ) {
        if (ROTATION_OBJ.password !== false) {
            if (ROTATION_OBJ.password === document.getElementById("pswdUnlock").value) {
        Severity: Minor
        Found in js/rotation.js - About 45 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            } else {
        $('#floater').addClass('hidden');

        $('#pauserotation').removeClass('hidden');
        $('#resumerotation').addClass('hidden');
        Severity: Minor
        Found in js/rotation.js and 1 other location - About 40 mins to fix
        js/rotation.js on lines 198..203

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (ROTATION_PAUSED) {
        $('#floater').removeClass('hidden');
        
        $('#pauserotation').addClass('hidden');
        $('#resumerotation').removeClass('hidden');
        Severity: Minor
        Found in js/rotation.js and 1 other location - About 40 mins to fix
        js/rotation.js on lines 203..208

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 48.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Avoid too many return statements within this function.
        Open

                    return true;
        Severity: Major
        Found in js/rotation.js - About 30 mins to fix
          Severity
          Category
          Status
          Source
          Language