spagalloco/em-twitter

View on GitHub

Showing 6 of 8 total issues

Class Connection has 26 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Connection < EM::Connection

      STALL_TIMEOUT   = 90 unless defined?(STALL_TIMEOUT)
      STALL_TIMER     = 10 unless defined?(STALL_TIMER)

Severity: Minor
Found in lib/em-twitter/connection.rb - About 3 hrs to fix

    Class Request has 23 methods (exceeds 20 allowed). Consider refactoring.
    Open

        class Request
    
          attr_reader :proxy, :options
    
          def initialize(options = {})
    Severity: Minor
    Found in lib/em-twitter/request.rb - About 2 hrs to fix

      Method ssl_verify_peer has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def ssl_verify_peer(cert_string)
              cert = nil
              begin
                cert = OpenSSL::X509::Certificate.new(cert_string)
              rescue OpenSSL::X509::CertificateError
      Severity: Minor
      Found in lib/em-twitter/connection.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method to_s has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

            def to_s
              content = query
      
              data = []
              data << "#{request_method} #{request_uri} HTTP/1.1"
      Severity: Minor
      Found in lib/em-twitter/request.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method params has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
      Open

            def params
              flat = {}
              @options[:params].each do |param, val|
                next if val.to_s.empty? || (val.respond_to?(:empty?) && val.empty?)
                val = val.join(",") if val.respond_to?(:join)
      Severity: Minor
      Found in lib/em-twitter/request.rb - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method concat has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

            def concat(data)
              @timestamp = Time.now
      
              return unless data && data.size > 0
      
      
      Severity: Minor
      Found in lib/em-twitter/response.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language