Sign upLogin

sparklemotion/nokogiri

View on GitHub
Star
ext/java/nokogiri/internals/c14n/AttrCompare.java

Summary

Maintainability
B
5 hrs
Test Coverage

Method compare has a Cognitive Complexity of 15 (exceeds 5 allowed). Consider refactoring.
Open

  public int
  compare(Attr attr0, Attr attr1)
  {
    String namespaceURI0 = attr0.getNamespaceURI();
    String namespaceURI1 = attr1.getNamespaceURI();
Severity: Minor
Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method compare has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public int
  compare(Attr attr0, Attr attr1)
  {
    String namespaceURI0 = attr0.getNamespaceURI();
    String namespaceURI1 = attr1.getNamespaceURI();
Severity: Minor
Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 1 hr to fix

    Avoid too many return statements within this method.
    Open

          return a;
    Severity: Major
    Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 30 mins to fix

      Avoid too many return statements within this method.
      Open

              return name0.compareTo(name1);
      Severity: Major
      Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

              return ATTR0_BEFORE_ATTR1;
        Severity: Major
        Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

              return (attr0.getLocalName()).compareTo(attr1.getLocalName());
          Severity: Major
          Found in ext/java/nokogiri/internals/c14n/AttrCompare.java - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status