sparklemotion/nokogiri

View on GitHub
lib/nokogiri/xml/document.rb

Summary

Maintainability
B
6 hrs
Test Coverage
A
100%

Class Document has 22 methods (exceeds 20 allowed). Consider refactoring.
Open

    class Document < Nokogiri::XML::Node
      # See http://www.w3.org/TR/REC-xml-names/#ns-decl for more details. Note that we're not
      # attempting to handle unicode characters partly because libxml2 doesn't handle unicode
      # characters in NCNAMEs.
      NCNAME_START_CHAR = "A-Za-z_"
Severity: Minor
Found in lib/nokogiri/xml/document.rb - About 2 hrs to fix

    Method parse has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
    Open

            def parse(string_or_io, url = nil, encoding = nil, options = ParseOptions::DEFAULT_XML)
              options = Nokogiri::XML::ParseOptions.new(options) if Integer === options
              yield options if block_given?
    
              url ||= string_or_io.respond_to?(:path) ? string_or_io.path : nil
    Severity: Minor
    Found in lib/nokogiri/xml/document.rb - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create_element has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

          def create_element(name, *contents_or_attrs, &block)
            elm = Nokogiri::XML::Element.new(name, self, &block)
            contents_or_attrs.each do |arg|
              case arg
              when Hash
    Severity: Minor
    Found in lib/nokogiri/xml/document.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method add_child has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def add_child(node_or_tags)
            raise "A document may not have multiple root nodes." if (root && root.name != "nokogiri_text_wrapper") && !(node_or_tags.comment? || node_or_tags.processing_instruction?)
    
            node_or_tags = coerce(node_or_tags)
            if node_or_tags.is_a?(XML::NodeSet)
    Severity: Minor
    Found in lib/nokogiri/xml/document.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method decorate has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

          def decorate(node)
            return unless @decorators
    
            @decorators.each do |klass, list|
              next unless node.is_a?(klass)
    Severity: Minor
    Found in lib/nokogiri/xml/document.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status