sparklemotion/nokogiri

View on GitHub
lib/nokogiri/xml/node_set.rb

Summary

Maintainability
C
7 hrs
Test Coverage
A
96%

Class NodeSet has 31 methods (exceeds 20 allowed). Consider refactoring.
Open

    class NodeSet
      include Nokogiri::XML::Searchable
      include Enumerable

      # The Document this NodeSet is associated with
Severity: Minor
Found in lib/nokogiri/xml/node_set.rb - About 3 hrs to fix

    Method to_html has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
    Open

          def to_html(*args)
            if Nokogiri.jruby?
              options = args.first.is_a?(Hash) ? args.shift : {}
              options[:save_with] ||= Node::SaveOptions::DEFAULT_HTML
              args.insert(0, options)
    Severity: Minor
    Found in lib/nokogiri/xml/node_set.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method index has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

          def index(node = nil)
            if node
              warn("given block not used") if block_given?
              each_with_index { |member, j| return j if member == node }
            elsif block_given?
    Severity: Minor
    Found in lib/nokogiri/xml/node_set.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method == has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def ==(other)
            return false unless other.is_a?(Nokogiri::XML::NodeSet)
            return false unless length == other.length
    
            each_with_index do |node, i|
    Severity: Minor
    Found in lib/nokogiri/xml/node_set.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method attr has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

          def attr(key, value = nil, &block)
            unless key.is_a?(Hash) || (key && (value || block))
              return first&.attribute(key)
            end
    
    
    Severity: Minor
    Found in lib/nokogiri/xml/node_set.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status