speedworks/speedy

View on GitHub
Core/Classes/Cookie.php

Summary

Maintainability
A
1 hr
Test Coverage

delete accesses the super-global variable $_SERVER.
Open

    public static function delete($cookieName = null)
    {
        if($cookieName == null)
        {
            if (isset($_SERVER['HTTP_COOKIE']))
Severity: Minor
Found in Core/Classes/Cookie.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

has accesses the super-global variable $_COOKIE.
Open

    public static function has($cookieName)
    {
        return isset($_COOKIE[$cookieName]);
    }
Severity: Minor
Found in Core/Classes/Cookie.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $_COOKIE.
Open

    public static function get($cookieName = null)
    {
        if($cookieName == null)
        {
            return $_COOKIE;
Severity: Minor
Found in Core/Classes/Cookie.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $_COOKIE.
Open

    public static function get($cookieName = null)
    {
        if($cookieName == null)
        {
            return $_COOKIE;
Severity: Minor
Found in Core/Classes/Cookie.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

delete accesses the super-global variable $_SERVER.
Open

    public static function delete($cookieName = null)
    {
        if($cookieName == null)
        {
            if (isset($_SERVER['HTTP_COOKIE']))
Severity: Minor
Found in Core/Classes/Cookie.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

get accesses the super-global variable $_COOKIE.
Open

    public static function get($cookieName = null)
    {
        if($cookieName == null)
        {
            return $_COOKIE;
Severity: Minor
Found in Core/Classes/Cookie.php by phpmd

Superglobals

Since: 0.2

Accessing a super-global variable directly is considered a bad practice. These variables should be encapsulated in objects that are provided by a framework, for instance.

Example

class Foo {
    public function bar() {
        $name = $_POST['foo'];
    }
}

Source

Method set has 7 arguments (exceeds 4 allowed). Consider refactoring.
Open

    public static function set($cookieName, $cookieValue=null, $expiryDays=365, $path=null, $domain=null, $secure=null, $httpOnly=null)
Severity: Major
Found in Core/Classes/Cookie.php - About 50 mins to fix

    Function delete has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        public static function delete($cookieName = null)
        {
            if($cookieName == null)
            {
                if (isset($_SERVER['HTTP_COOKIE']))
    Severity: Minor
    Found in Core/Classes/Cookie.php - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    There are no issues that match your filters.

    Category
    Status