Sign upLogin

speedworks/speedy

View on GitHub
Star

Showing 149 of 149 total issues

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function where()
    {
        $numArgs = func_num_args();
        $args = func_get_args();
        $col = null;
Severity: Major
Found in Core/Classes/DB.php and 1 other location - About 7 hrs to fix
Core/Classes/DB.php on lines 139..173

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 237.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    public function orWhere()
    {
        $numArgs = func_num_args();
        $args = func_get_args();
        $col = null;
Severity: Major
Found in Core/Classes/DB.php and 1 other location - About 7 hrs to fix
Core/Classes/DB.php on lines 99..133

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 237.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function GiveError has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring.
Open

    public static function GiveError($errorCode, $errorMessage)
    {
        if($errorCode==400)
        {
            header("HTTP/1.0 400 Bad Request");
Severity: Minor
Found in Core/Classes/System.php - About 6 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function selectionQueryMaker has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring.
Open

    protected function selectionQueryMaker()
    {
        $this->query = 'SELECT '.$this->selects.' FROM '.$this->table;
        $where="";
        $flag = 0;
Severity: Minor
Found in Core/Classes/DB.php - About 3 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

The class DB has 11 public methods. Consider refactoring DB to keep number of public methods under 10.
Open

class DB
{
    private $dsn=null;
    private $DBCON=null;
    private $table=null;
Severity: Minor
Found in Core/Classes/DB.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

The class System has 12 public methods. Consider refactoring System to keep number of public methods under 10.
Open

class System
{
    /**
     * System constructor.
     */
Severity: Minor
Found in Core/Classes/System.php by phpmd

TooManyPublicMethods

Since: 0.1

A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.

By default it ignores methods starting with 'get' or 'set'.

Example

Source https://phpmd.org/rules/codesize.html#toomanypublicmethods

Method selectionQueryMaker has 75 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function selectionQueryMaker()
    {
        $this->query = 'SELECT '.$this->selects.' FROM '.$this->table;
        $where="";
        $flag = 0;
Severity: Major
Found in Core/Classes/DB.php - About 3 hrs to fix

    Method ErrorHandler has 75 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    function ErrorHandler($errno, $errstr, $errfile, $errline)
{
    if (!(error_reporting() & $errno))
    {
        return;
    Severity: Major
    Found in public/index.php - About 3 hrs to fix

      Function FilterInput has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring.
      Open

          public static function FilterInput($inData, $keepHTML=false)
    {
        if(is_array($inData))
        {
            $outData=array();
      Severity: Minor
      Found in Core/Classes/System.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Authenticate has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function Authenticate()
    {
        $auth = new BaseAuth();
        if($this->type == "KEY")
        {
      Severity: Minor
      Found in Core/Middleware/Auth.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function Authorize has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
      Open

          public function Authorize($authType, $redirectTo=null)
    {
        $auth = new BaseAuth();
        if($authType == "session")
        {
      Severity: Minor
      Found in Core/Middleware/Auth.php - About 2 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File DB.php has 251 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
/**
 * Created by PhpStorm.
 * @Author : Shakti Phartiyal
 * Date: 11/29/16
      Severity: Minor
      Found in Core/Classes/DB.php - About 2 hrs to fix

        Method GiveError has 43 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            public static function GiveError($errorCode, $errorMessage)
    {
        if($errorCode==400)
        {
            header("HTTP/1.0 400 Bad Request");
        Severity: Minor
        Found in Core/Classes/System.php - About 1 hr to fix

          Method FilterInput has 39 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

              public static function FilterInput($inData, $keepHTML=false)
    {
        if(is_array($inData))
        {
            $outData=array();
          Severity: Minor
          Found in Core/Classes/System.php - About 1 hr to fix

            Function where has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function where()
    {
        $numArgs = func_num_args();
        $args = func_get_args();
        $col = null;
            Severity: Minor
            Found in Core/Classes/DB.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function orWhere has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
            Open

                public function orWhere()
    {
        $numArgs = func_num_args();
        $args = func_get_args();
        $col = null;
            Severity: Minor
            Found in Core/Classes/DB.php - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Method Pass has 34 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                public static function Pass($requestUri, $requestMethod, $requestData, $rawData)
    {
        if(!array_key_exists($requestMethod,Route::$URLS))
        {
            System::GiveError(405,"Method not allowed");
            Severity: Minor
            Found in Core/Bridge.php - About 1 hr to fix

              Avoid using short method names like Mailer::cc(). The configured minimum method name length is 3.
              Open

                  public function cc($cc)
    {
        if(is_array($cc))
        {
            foreach ($cc as $copy)
              Severity: Minor
              Found in Core/Classes/Mailer.php by phpmd

              ShortMethodName

              Since: 0.2

              Detects when very short method names are used.

              Example

              class ShortMethod {
    public function a( $index ) { // Violation
    }
}

              Source https://phpmd.org/rules/naming.html#shortmethodname

              Avoid using short method names like Mailer::to(). The configured minimum method name length is 3.
              Open

                  public function to($recipients)
    {
        if(is_array($recipients))
        {
            foreach ($recipients as $recipient)
              Severity: Minor
              Found in Core/Classes/Mailer.php by phpmd

              ShortMethodName

              Since: 0.2

              Detects when very short method names are used.

              Example

              class ShortMethod {
    public function a( $index ) { // Violation
    }
}

              Source https://phpmd.org/rules/naming.html#shortmethodname

              Method corePHPMailer has 33 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                  private function corePHPMailer($options)
    {
        $options = null;
        $this->mailHeaders[] = "MIME-Version: 1.0";
        $this->mailHeaders[] = "Content-Type: ".$this->mailContentType;
              Severity: Minor
              Found in Core/Classes/Mailer.php - About 1 hr to fix
                Severity
                Category
                Status
                Source
                Language