Showing 32 of 149 total issues
Function GiveError
has a Cognitive Complexity of 45 (exceeds 5 allowed). Consider refactoring. Open
public static function GiveError($errorCode, $errorMessage)
{
if($errorCode==400)
{
header("HTTP/1.0 400 Bad Request");
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function selectionQueryMaker
has a Cognitive Complexity of 24 (exceeds 5 allowed). Consider refactoring. Open
protected function selectionQueryMaker()
{
$this->query = 'SELECT '.$this->selects.' FROM '.$this->table;
$where="";
$flag = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
The class System has 12 public methods. Consider refactoring System to keep number of public methods under 10. Open
class System
{
/**
* System constructor.
*/
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
The class DB has 11 public methods. Consider refactoring DB to keep number of public methods under 10. Open
class DB
{
private $dsn=null;
private $DBCON=null;
private $table=null;
- Read upRead up
- Exclude checks
TooManyPublicMethods
Since: 0.1
A class with too many public methods is probably a good suspect for refactoring, in order to reduce its complexity and find a way to have more fine grained objects.
By default it ignores methods starting with 'get' or 'set'.
Example
Source https://phpmd.org/rules/codesize.html#toomanypublicmethods
Method ErrorHandler
has 75 lines of code (exceeds 25 allowed). Consider refactoring. Open
function ErrorHandler($errno, $errstr, $errfile, $errline)
{
if (!(error_reporting() & $errno))
{
return;
Method selectionQueryMaker
has 75 lines of code (exceeds 25 allowed). Consider refactoring. Open
protected function selectionQueryMaker()
{
$this->query = 'SELECT '.$this->selects.' FROM '.$this->table;
$where="";
$flag = 0;
Function FilterInput
has a Cognitive Complexity of 18 (exceeds 5 allowed). Consider refactoring. Open
public static function FilterInput($inData, $keepHTML=false)
{
if(is_array($inData))
{
$outData=array();
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Authorize
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function Authorize($authType, $redirectTo=null)
{
$auth = new BaseAuth();
if($authType == "session")
{
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function Authenticate
has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring. Open
public function Authenticate()
{
$auth = new BaseAuth();
if($this->type == "KEY")
{
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File DB.php
has 251 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
/**
* Created by PhpStorm.
* @Author : Shakti Phartiyal
* Date: 11/29/16
Method GiveError
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function GiveError($errorCode, $errorMessage)
{
if($errorCode==400)
{
header("HTTP/1.0 400 Bad Request");
Method FilterInput
has 39 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function FilterInput($inData, $keepHTML=false)
{
if(is_array($inData))
{
$outData=array();
Function where
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
public function where()
{
$numArgs = func_num_args();
$args = func_get_args();
$col = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function orWhere
has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring. Open
public function orWhere()
{
$numArgs = func_num_args();
$args = func_get_args();
$col = null;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method Pass
has 34 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function Pass($requestUri, $requestMethod, $requestData, $rawData)
{
if(!array_key_exists($requestMethod,Route::$URLS))
{
System::GiveError(405,"Method not allowed");
Method corePHPMailer
has 33 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function corePHPMailer($options)
{
$options = null;
$this->mailHeaders[] = "MIME-Version: 1.0";
$this->mailHeaders[] = "Content-Type: ".$this->mailContentType;
Method where
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function where()
{
$numArgs = func_num_args();
$args = func_get_args();
$col = null;
Method orWhere
has 32 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function orWhere()
{
$numArgs = func_num_args();
$args = func_get_args();
$col = null;
Method Authorize
has 28 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function Authorize($authType, $redirectTo=null)
{
$auth = new BaseAuth();
if($authType == "session")
{
Method view
has 27 lines of code (exceeds 25 allowed). Consider refactoring. Open
public static function view($view, $arrayParams = [], $exit = false)
{
$loader = new Twig_Loader_Filesystem(__DIR__.'/../../Views');
$cache = __DIR__.'/../../Storage/Cache/Views';
if(!$_ENV['cache_template'])