Sign upLogin

sprawl/sprawl

View on GitHub
Star

Showing 7 of 12 total issues

Method OrderService.Receive has a Cognitive Complexity of 98 (exceeds 20 allowed). Consider refactoring.
Confirmed

func (s *OrderService) Receive(buf []byte, from peer.ID) error {
    wireMessage := &pb.WireMessage{}
    err := proto.Unmarshal(buf, wireMessage)
    if !errors.IsEmpty(err) {
        return errors.E(errors.Op("Unmarshal wiremessage proto in Receive"), err)
Severity: Minor
Found in service/order.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (s *OrderService) Unlock(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {

    orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
    if !errors.IsEmpty(err) {
        return nil, errors.E(errors.Op("Get order in Unlock"), err)
Severity: Major
Found in service/order.go and 1 other location - About 1 day to fix
service/order.go on lines 401..456

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 602.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

func (s *OrderService) Lock(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {

    orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
    if !errors.IsEmpty(err) {
        return nil, errors.E(errors.Op("Get order in Lock"), err)
Severity: Major
Found in service/order.go and 1 other location - About 1 day to fix
service/order.go on lines 459..515

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 602.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Method OrderService.Receive has 143 lines of code (exceeds 50 allowed). Consider refactoring.
Confirmed

func (s *OrderService) Receive(buf []byte, from peer.ID) error {
    wireMessage := &pb.WireMessage{}
    err := proto.Unmarshal(buf, wireMessage)
    if !errors.IsEmpty(err) {
        return errors.E(errors.Op("Unmarshal wiremessage proto in Receive"), err)
Severity: Major
Found in service/order.go - About 4 hrs to fix

    Method OrderService.Lock has 6 return statements (exceeds 4 allowed).
    Open

    func (s *OrderService) Lock(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {

    orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
    if !errors.IsEmpty(err) {
        return nil, errors.E(errors.Op("Get order in Lock"), err)
    Severity: Major
    Found in service/order.go - About 40 mins to fix

      Method OrderService.Delete has 6 return statements (exceeds 4 allowed).
      Open

      func (s *OrderService) Delete(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {
    orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
    if !errors.IsEmpty(err) {
        return nil, errors.E(errors.Op("Delete order"), err)
    }
      Severity: Major
      Found in service/order.go - About 40 mins to fix

        Method OrderService.Unlock has 6 return statements (exceeds 4 allowed).
        Open

        func (s *OrderService) Unlock(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {

    orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
    if !errors.IsEmpty(err) {
        return nil, errors.E(errors.Op("Get order in Unlock"), err)
        Severity: Major
        Found in service/order.go - About 40 mins to fix
          Severity
          Category
          Status
          Source
          Language