sprawl/sprawl

View on GitHub

Showing 5 of 12 total issues

Method OrderService.Receive has a Cognitive Complexity of 98 (exceeds 20 allowed). Consider refactoring.
Confirmed

func (s *OrderService) Receive(buf []byte, from peer.ID) error {
    wireMessage := &pb.WireMessage{}
    err := proto.Unmarshal(buf, wireMessage)
    if !errors.IsEmpty(err) {
        return errors.E(errors.Op("Unmarshal wiremessage proto in Receive"), err)
Severity: Minor
Found in service/order.go - About 1 day to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method OrderService.Receive has 143 lines of code (exceeds 50 allowed). Consider refactoring.
Confirmed

func (s *OrderService) Receive(buf []byte, from peer.ID) error {
    wireMessage := &pb.WireMessage{}
    err := proto.Unmarshal(buf, wireMessage)
    if !errors.IsEmpty(err) {
        return errors.E(errors.Op("Unmarshal wiremessage proto in Receive"), err)
Severity: Major
Found in service/order.go - About 4 hrs to fix

    Method OrderService.Lock has 6 return statements (exceeds 4 allowed).
    Open

    func (s *OrderService) Lock(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {
    
        orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
        if !errors.IsEmpty(err) {
            return nil, errors.E(errors.Op("Get order in Lock"), err)
    Severity: Major
    Found in service/order.go - About 40 mins to fix

      Method OrderService.Delete has 6 return statements (exceeds 4 allowed).
      Open

      func (s *OrderService) Delete(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {
          orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
          if !errors.IsEmpty(err) {
              return nil, errors.E(errors.Op("Delete order"), err)
          }
      Severity: Major
      Found in service/order.go - About 40 mins to fix

        Method OrderService.Unlock has 6 return statements (exceeds 4 allowed).
        Open

        func (s *OrderService) Unlock(ctx context.Context, in *pb.OrderSpecificRequest) (*pb.Empty, error) {
        
            orderInBytes, err := s.Storage.Get(getOrderStorageKey(in.GetChannelID(), in.GetOrderID()))
            if !errors.IsEmpty(err) {
                return nil, errors.E(errors.Op("Get order in Unlock"), err)
        Severity: Major
        Found in service/order.go - About 40 mins to fix
          Severity
          Category
          Status
          Source
          Language